Support reloading consuming segment using force commit #9640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackie-Jiang
force-pushed
the
reload_consuming_segment
branch
2 times, most recently
from
baad5f2 to
07a6ad7
Compare
@Jackie-Jiang I will go ahead and delete the PR I started as you pushed the change here. Thanks for driving it as I have been real busy at work these days |
|
@jugomezv Thanks for trying it out. I didn't realize it requires changing the integration test in the beginning |
Jackie-Jiang
force-pushed
the
reload_consuming_segment
branch
from
07a6ad7 to
6bbce06
Compare
Jackie-Jiang
force-pushed
the
reload_consuming_segment
branch
from
6bbce06 to
7fa61a3
Compare
Codecov Report
@@ Coverage Diff @@
## master #9640 +/- ##
=============================================
+ Coverage 28.09% 68.58% +40.49%
- Complexity 53 5308 +5255
=============================================
Files 1935 1947 +12
Lines 103815 104145 +330
Branches 15758 15790 +32
=============================================
+ Hits 29162 71431 +42269
+ Misses 71780 27664 -44116
- Partials 2873 5050 +2177
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Jackie-Jiang
force-pushed
the
reload_consuming_segment
branch
from
7fa61a3 to
e49842b
Compare
siddharthteotia
approved these changes
Oct 27, 2022
| } | ||
| LOGGER.info("Reloading (force committing) LLC consuming segment: {} in table: {}", segmentName, | ||
| tableNameWithType); | ||
| ((LLRealtimeSegmentDataManager) segmentDataManager).forceCommit(); |
There was a problem hiding this comment.
So forceCommit is async ?
There was a problem hiding this comment.
Yes, it is async. We can only signal the segment to perform the commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another try of #9310