Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance cluster config update API to handle non-string values properly #9635

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

Jackie-Jiang
Copy link
Contributor

  • Process non-string value from json input properly when updating the cluster config
  • Reduce ZK access when multiple configs are updated
  • Manually tested

@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2022

Codecov Report

Merging #9635 (839e096) into master (273e1de) will decrease coverage by 4.61%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##             master    #9635      +/-   ##
============================================
- Coverage     68.43%   63.81%   -4.62%     
+ Complexity     4929     4907      -22     
============================================
  Files          1947     1894      -53     
  Lines        104165   101786    -2379     
  Branches      15794    15518     -276     
============================================
- Hits          71283    64953    -6330     
- Misses        27824    32076    +4252     
+ Partials       5058     4757     -301     
Flag Coverage Δ
integration2 ?
unittests1 67.37% <ø> (+0.03%) ⬆️
unittests2 15.66% <75.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../controller/api/resources/PinotClusterConfigs.java 36.58% <75.00%> (+2.37%) ⬆️
...va/org/apache/pinot/core/routing/RoutingTable.java 0.00% <0.00%> (-100.00%) ⬇️
...va/org/apache/pinot/common/config/NettyConfig.java 0.00% <0.00%> (-100.00%) ⬇️
...a/org/apache/pinot/common/metrics/MinionMeter.java 0.00% <0.00%> (-100.00%) ⬇️
...g/apache/pinot/common/metrics/ControllerMeter.java 0.00% <0.00%> (-100.00%) ⬇️
.../apache/pinot/common/metrics/BrokerQueryPhase.java 0.00% <0.00%> (-100.00%) ⬇️
.../apache/pinot/common/metrics/MinionQueryPhase.java 0.00% <0.00%> (-100.00%) ⬇️
...ache/pinot/server/access/AccessControlFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...he/pinot/common/messages/SegmentReloadMessage.java 0.00% <0.00%> (-100.00%) ⬇️
...he/pinot/common/messages/TableDeletionMessage.java 0.00% <0.00%> (-100.00%) ⬇️
... and 381 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Jackie-Jiang Jackie-Jiang merged commit fafb518 into apache:master Oct 21, 2022
@Jackie-Jiang Jackie-Jiang deleted the cluster_config branch October 21, 2022 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants