Fix re-uploading segment when the previous upload failed #9631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackie-Jiang
changed the title
Codecov Report
@@ Coverage Diff @@
## master #9631 +/- ##
============================================
- Coverage 69.92% 68.68% -1.24%
+ Complexity 4930 4924 -6
============================================
Files 1943 1943
Lines 103907 103926 +19
Branches 15745 15750 +5
============================================
- Hits 72653 71381 -1272
- Misses 26153 27456 +1303
+ Partials 5101 5089 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
siddharthteotia
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the segment upload fails after segment ZK metadata is created but before segment is assigned to the ideal state, and the following cleanup didn't run properly (e.g. hard failure, disconnect from ZK), the next upload should be able to recover the previous failure and re-assign the segment (treat the uploaded segment as a new segment)