-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix DataSchema thread-safe issue #9619
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9619 +/- ##
============================================
+ Coverage 60.33% 63.80% +3.47%
- Complexity 5148 5299 +151
============================================
Files 1926 1890 -36
Lines 103209 101451 -1758
Branches 15670 15467 -203
============================================
+ Hits 62266 64733 +2467
+ Misses 36271 31983 -4288
- Partials 4672 4735 +63
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! elegant fix - we may want to leave some comments inline explaining that this is necessary for thread-safety so it doesn't get refactored away
Observed some NPE occuring in multistage engine for stored column data type.
this is b/c the data schema object were created during distributed stage planner to create the operator chain