Bump up ZK version to 3.6.3 #9612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackjlli
force-pushed
the
bump-up-zk-version
branch
from
19fe535 to
8303f92
Compare
Codecov Report
@@ Coverage Diff @@
## master #9612 +/- ##
=============================================
+ Coverage 37.00% 70.00% +33.00%
- Complexity 198 5325 +5127
=============================================
Files 1941 1939 -2
Lines 103572 103671 +99
Branches 15703 15727 +24
=============================================
+ Hits 38331 72580 +34249
+ Misses 62048 25992 -36056
- Partials 3193 5099 +1906
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jackjlli
force-pushed
the
bump-up-zk-version
branch
from
8303f92 to
467e5c1
Compare
walterddr
reviewed
Oct 18, 2022
| @@ -107,6 +107,10 @@ | |||
| <groupId>net.sf.jopt-simple</groupId> | |||
| <artifactId>jopt-simple</artifactId> | |||
| </dependency> | |||
| <dependency> | |||
There was a problem hiding this comment.
Is this pom change related to zk version upgrade?
There was a problem hiding this comment.
Unfortunately yes, the metric-core module is required. Otherwise, the following exception would be thrown:
Error: org.apache.pinot.plugin.stream.kafka20.KafkaPartitionLevelConsumerBackwardCompatibilityTest.setUp Time elapsed: 0.906 s <<< FAILURE!
java.lang.NoClassDefFoundError: com/codahale/metrics/Reservoir
at org.apache.zookeeper.metrics.impl.DefaultMetricsProvider$DefaultMetricsContext.lambda$getSummary$2(DefaultMetricsProvider.java:126)
at java.base/java.util.concurrent.ConcurrentHashMap.computeIfAbsent(ConcurrentHashMap.java:1705)
at org.apache.zookeeper.metrics.impl.DefaultMetricsProvider$DefaultMetricsContext.getSummary(DefaultMetricsProvider.java:122)
at org.apache.zookeeper.server.ServerMetrics.<init>(ServerMetrics.java:74)
at org.apache.zookeeper.server.ServerMetrics.<clinit>(ServerMetrics.java:44)
at org.apache.zookeeper.server.persistence.FileTxnSnapLog.restore(FileTxnSnapLog.java:246)
at org.apache.zookeeper.server.ZKDatabase.loadDataBase(ZKDatabase.java:285)
at org.apache.zookeeper.server.ZooKeeperServer.loadData(ZooKeeperServer.java:494)
at org.apache.zookeeper.server.ZooKeeperServer.startdata(ZooKeeperServer.java:665)
at org.apache.zookeeper.server.NIOServerCnxnFactory.startup(NIOServerCnxnFactory.java:758)
at org.apache.zookeeper.server.ServerCnxnFactory.startup(ServerCnxnFactory.java:130)
at org.apache.pinot.plugin.stream.kafka20.utils.EmbeddedZooKeeper.<init>(EmbeddedZooKeeper.java:42)
at org.apache.pinot.plugin.stream.kafka20.utils.MiniKafkaCluster.<init>(MiniKafkaCluster.java:54)
at org.apache.pinot.plugin.stream.kafka20.KafkaPartitionLevelConsumerTest.setUp(KafkaPartitionLevelConsumerTest.java:63)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:108)
at org.testng.internal.Invoker.invokeConfigurationMethod(Invoker.java:523)
at org.testng.internal.Invoker.invokeConfigurations(Invoker.java:224)
at org.testng.internal.Invoker.invokeConfigurations(Invoker.java:146)
at org.testng.internal.TestMethodWorker.invokeBeforeClassMethods(TestMethodWorker.java:166)
at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:105)
at org.testng.TestRunner.privateRun(TestRunner.java:744)
at org.testng.TestRunner.run(TestRunner.java:602)
at org.testng.SuiteRunner.runTest(SuiteRunner.java:380)
at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:375)
at org.testng.SuiteRunner.privateRun(SuiteRunner.java:340)
at org.testng.SuiteRunner.run(SuiteRunner.java:289)
at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86)
at org.testng.TestNG.runSuitesSequentially(TestNG.java:1301)
at org.testng.TestNG.runSuitesLocally(TestNG.java:1226)
at org.testng.TestNG.runSuites(TestNG.java:1144)
at org.testng.TestNG.run(TestNG.java:1115)
at org.apache.maven.surefire.testng.TestNGExecutor.run(TestNGExecutor.java:136)
at org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.executeSingleClass(TestNGDirectoryTestSuite.java:112)
at org.apache.maven.surefire.testng.TestNGDirectoryTestSuite.execute(TestNGDirectoryTestSuite.java:99)
at org.apache.maven.surefire.testng.TestNGProvider.invoke(TestNGProvider.java:145)
at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:428)
at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:162)
at org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:562)
at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:548)
Caused by: java.lang.ClassNotFoundException: com.codahale.metrics.Reservoir
at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:581)
at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178)
at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522)
... 44 more
I can try restrict the scope of that dependency to test only, as I can build it locally when running tests is disabled.
There was a problem hiding this comment.
Changing it test scope works. It seems ServerCnxnFactory is only used in test classes, so we should be good with the current changes in this PR.
jackjlli
force-pushed
the
bump-up-zk-version
branch
from
467e5c1 to
ccfdba0
Compare
siddharthteotia
approved these changes
Oct 19, 2022
walterddr
approved these changes
Oct 19, 2022
Jackie-Jiang
added
the
release-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In LinkedIn the ZK version has already been bumped up to 3.6.3 and it's working as expected.
This PR bumps up ZK version to 3.6.3 in the Apache Pinot repo.
Issue: #9431