-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add segment level debug API #9609
Conversation
Thanks @saurabhd336! As a Pinot newbie trying to understand how things work better this will be really helpful, can you paste a sample output in the PR description? |
@ApiResponse(code = 500, message = "Internal server error") | ||
}) | ||
public TableDebugInfo.SegmentDebugInfo getSegmentDebugInfo( | ||
@ApiParam(value = "Name of the table (with type)", required = true) @PathParam("tableName") String tableName, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(minor)
@ApiParam(value = "Name of the table (with type)", required = true) @PathParam("tableName") String tableName, | |
@ApiParam(value = "Name of the table (with type)", required = true) @PathParam("tableName") String tableNameWithType, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack
@ApiOperation(value = "Get segment debug info", | ||
notes = "This is a debug endpoint, and won't maintain backward compatibility") | ||
public SegmentServerDebugInfo getSegmentDebugInfo( | ||
@ApiParam(value = "Name of the table", required = true) @PathParam("tableName") String tableNameWithType, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same for the table level one
@ApiParam(value = "Name of the table", required = true) @PathParam("tableName") String tableNameWithType, | |
@ApiParam(value = "Name of the table (with type)", required = true) @PathParam("tableName") String tableNameWithType, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack
7026ffc
to
ebd5794
Compare
@agavra Added a sample response! |
ebd5794
to
2f103db
Compare
Codecov Report
@@ Coverage Diff @@
## master #9609 +/- ##
============================================
- Coverage 69.92% 69.87% -0.05%
+ Complexity 4930 4853 -77
============================================
Files 1943 1943
Lines 103907 103960 +53
Branches 15745 15753 +8
============================================
- Hits 72653 72640 -13
- Misses 26153 26212 +59
- Partials 5101 5108 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This PR adds a segment level debug API that aims to make the debugging of segment state mismatches easier. The API will return the same information as the
/debug/table/{tableName}
API, but at the segment name level instead. A similar debug API has been added at the server level too. The controller API calls the server level APIs for the all the servers hosting the segment.Sample responses: