Using usageHelp instead of deprecated help in picocli commands
#9608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinot-perf/src/main/java/org/apache/pinot/perf/RawIndexBenchmark.java
Outdated
Show resolved
Hide resolved
pinot-tools/src/main/java/org/apache/pinot/tools/AutoAddInvertedIndexTool.java
Outdated
Show resolved
Hide resolved
pinot-tools/src/main/java/org/apache/pinot/tools/SegmentDumpTool.java
Outdated
Show resolved
Hide resolved
...ls/src/main/java/org/apache/pinot/tools/admin/command/RealtimeProvisioningHelperCommand.java
Outdated
Show resolved
Hide resolved
pinot-tools/src/main/java/org/apache/pinot/tools/perf/PerfBenchmarkRunner.java
Show resolved
Hide resolved
…pdate PinotToolLauncher to use the correct log4j
Codecov Report
@@ Coverage Diff @@
## master #9608 +/- ##
=============================================
+ Coverage 28.06% 62.81% +34.74%
- Complexity 53 4707 +4654
=============================================
Files 1935 1935
Lines 103815 103815
Branches 15757 15757
=============================================
+ Hits 29134 65207 +36073
+ Misses 71808 33729 -38079
- Partials 2873 4879 +2006
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Jackie-Jiang
approved these changes
Oct 25, 2022
| } else { | ||
| perfBenchmarkRunner.execute(); | ||
| } | ||
| commandLine.execute(); |
There was a problem hiding this comment.
Should not ignore the help
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the commands don't print help properly due to the use of a deprecated
helpannotation. This PT attempts to clean-up some of the commands launched byPinotToolLauncher.Labels:
cleanup