Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused RecordTransform/RecordFilter classes #9607

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

agavra
Copy link
Contributor

@agavra agavra commented Oct 16, 2022

these classes were used as part of the segment processing framework (https://docs.google.com/document/d/1-e_9aHQB4HXS38ONtofdxNvMsGmAoYfSnc2LP88MbIc/edit#heading=h.ths3qhhyyy7w) but this portion (record filtering/record transform) were moved to reuse the existing ingestion code and therefore this is unused

cc @npawar

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2022

Codecov Report

Merging #9607 (fdf14dc) into master (a8d95f2) will decrease coverage by 6.09%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #9607      +/-   ##
============================================
- Coverage     69.95%   63.85%   -6.10%     
+ Complexity     4946     4922      -24     
============================================
  Files          1936     1881      -55     
  Lines        103474   101116    -2358     
  Branches      15714    15437     -277     
============================================
- Hits          72383    64568    -7815     
- Misses        25984    31814    +5830     
+ Partials       5107     4734     -373     
Flag Coverage Δ
integration1 ?
integration2 ?
unittests1 67.37% <ø> (-0.05%) ⬇️
unittests2 15.60% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...va/org/apache/pinot/core/routing/RoutingTable.java 0.00% <0.00%> (-100.00%) ⬇️
...va/org/apache/pinot/common/config/NettyConfig.java 0.00% <0.00%> (-100.00%) ⬇️
...a/org/apache/pinot/common/metrics/MinionMeter.java 0.00% <0.00%> (-100.00%) ⬇️
...g/apache/pinot/common/metrics/ControllerMeter.java 0.00% <0.00%> (-100.00%) ⬇️
.../apache/pinot/common/metrics/BrokerQueryPhase.java 0.00% <0.00%> (-100.00%) ⬇️
.../apache/pinot/common/metrics/MinionQueryPhase.java 0.00% <0.00%> (-100.00%) ⬇️
...ache/pinot/server/access/AccessControlFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...he/pinot/common/messages/SegmentReloadMessage.java 0.00% <0.00%> (-100.00%) ⬇️
...he/pinot/common/messages/TableDeletionMessage.java 0.00% <0.00%> (-100.00%) ⬇️
...pinot/core/data/manager/realtime/TimerService.java 0.00% <0.00%> (-100.00%) ⬇️
... and 431 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@walterddr walterddr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@walterddr walterddr merged commit 52d0edd into apache:master Oct 17, 2022
@Jackie-Jiang
Copy link
Contributor

We should also remove the RecordFilter interface and implementations?

@agavra agavra deleted the remove_unused branch October 18, 2022 15:45
@agavra
Copy link
Contributor Author

agavra commented Oct 18, 2022

@Jackie-Jiang - didn't realize that was part of it :) i'll open a new PR for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants