Fix the bug where uploaded segments cannot be deleted on real-time table #9579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9579 +/- ##
=============================================
+ Coverage 26.03% 63.85% +37.82%
- Complexity 44 5240 +5196
=============================================
Files 1922 1881 -41
Lines 102937 100962 -1975
Branches 15657 15419 -238
=============================================
+ Hits 26796 64469 +37673
+ Misses 73435 31768 -41667
- Partials 2706 4725 +2019
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
walterddr
approved these changes
Oct 12, 2022
Comment on lines
+93
to
+106
| // Test dropping all segments one by one | ||
| List<String> segments = listSegments(realtimeTableName); | ||
| assertFalse(segments.isEmpty()); | ||
| for (String segment : segments) { | ||
| dropSegment(realtimeTableName, segment); | ||
| } | ||
| // NOTE: There is a delay to remove the segment from property store | ||
| TestUtils.waitForCondition((aVoid) -> { | ||
| try { | ||
| return listSegments(realtimeTableName).isEmpty(); | ||
| } catch (IOException e) { | ||
| throw new RuntimeException(e); | ||
| } | ||
| }, 60_000L, "Failed to drop the segments"); |
There was a problem hiding this comment.
nit, why is this test during tearDown?
There was a problem hiding this comment.
This is part of the tear-down process. OfflineClusterIntegrationTest has similar test. We may consider adding dependency to the test so that we can move it into a test, but prefer doing it separately
There was a problem hiding this comment.
yeah good enough for now we can follow up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #8283
Since we added the support of uploading segments to real-time table, we cannot always derive the table type from the segment name. When the provided table name has the type suffix, do not try to derive the table type from the segment name.