Fix time validation when data type needs to be converted #9569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackjlli
approved these changes
Oct 11, 2022
KKcorps
reviewed
Oct 12, 2022
| _timeFormatSpec = dateTimeFieldSpec.getFormatSpec(); | ||
| IngestionConfig ingestionConfig = tableConfig.getIngestionConfig(); | ||
| if (ingestionConfig != null) { | ||
| _skipTimeValueCheck = !ingestionConfig.isRowTimeValueCheck(); |
There was a problem hiding this comment.
Why not use the original flag here instead of doing !isRowTimeValueCheck
There was a problem hiding this comment.
I'm debating a little bit on having the default value as true, but checked with @xiangfu0 and I believe the default behavior of having row value check on is by mistake (different from the existing behavior), so I'll change it to use the original flag
Jackie-Jiang
force-pushed
the
fix_time_validation
branch
2 times, most recently
from
dc13fd4 to
7fff03f
Compare
xiangfu0
approved these changes
Oct 12, 2022
Jackie-Jiang
force-pushed
the
fix_time_validation
branch
from
7fff03f to
3799b24
Compare
Codecov Report
@@ Coverage Diff @@
## master #9569 +/- ##
============================================
- Coverage 69.90% 63.83% -6.08%
- Complexity 4875 4895 +20
============================================
Files 1931 1881 -50
Lines 103117 100949 -2168
Branches 15654 15420 -234
============================================
- Hits 72088 64438 -7650
- Misses 25954 31785 +5831
+ Partials 5075 4726 -349
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the time validation into a separate record transformer:
TimeValidationTransformerwith the following bugfixes/enhancements:IngestionConfig, and the same as the old behavior before default enabled row based time validation was introduced in Refactor timeValueCheck for Pinot TableConfig #9349)isNoOp()API toRecordTransformerso that no-op transformers can be skipped