Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose task finish time via debug API #9534

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

klsince
Copy link
Contributor

@klsince klsince commented Oct 4, 2022

Refine the tasks/debug API a bit to also expose the task FinishTime.

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2022

Codecov Report

Merging #9534 (05e7c72) into master (e1aa147) will decrease coverage by 1.24%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #9534      +/-   ##
============================================
- Coverage     69.87%   68.63%   -1.25%     
+ Complexity     5202     4865     -337     
============================================
  Files          1927     1927              
  Lines        102693   102703      +10     
  Branches      15586    15587       +1     
============================================
- Hits          71760    70489    -1271     
- Misses        25873    27164    +1291     
+ Partials       5060     5050      -10     
Flag Coverage Δ
integration1 26.00% <0.00%> (+0.02%) ⬆️
integration2 ?
unittests1 67.23% <ø> (-0.01%) ⬇️
unittests2 15.57% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lix/core/minion/PinotHelixTaskResourceManager.java 41.43% <0.00%> (-0.04%) ⬇️
...t/core/plan/StreamingInstanceResponsePlanNode.java 0.00% <0.00%> (-100.00%) ⬇️
...ore/operator/streaming/StreamingResponseUtils.java 0.00% <0.00%> (-100.00%) ⬇️
...server/starter/helix/SegmentReloadStatusValue.java 0.00% <0.00%> (-100.00%) ⬇️
.../operator/blocks/results/MetadataResultsBlock.java 0.00% <0.00%> (-100.00%) ⬇️
...ager/realtime/PeerSchemeSplitSegmentCommitter.java 0.00% <0.00%> (-100.00%) ⬇️
...urces/ServerReloadControllerJobStatusResponse.java 0.00% <0.00%> (-100.00%) ⬇️
...he/pinot/common/utils/grpc/GrpcRequestBuilder.java 0.00% <0.00%> (-90.91%) ⬇️
...ator/streaming/StreamingSelectionOnlyOperator.java 0.00% <0.00%> (-90.00%) ⬇️
...he/pinot/core/plan/StreamingSelectionPlanNode.java 0.00% <0.00%> (-88.89%) ⬇️
... and 145 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@klsince klsince force-pushed the debug_api_expose_task_finish_time branch from 6025680 to 05e7c72 Compare October 5, 2022 17:20
@npawar npawar merged commit fe91910 into apache:master Oct 5, 2022
@klsince klsince deleted the debug_api_expose_task_finish_time branch October 5, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants