Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to config task expire time #9530

Merged
merged 2 commits into from
Oct 5, 2022

Conversation

klsince
Copy link
Contributor

@klsince klsince commented Oct 4, 2022

Allows to customize how often to purge ended tasks from Helix, the default is 24hr.

Release note

  1. controller.task.expire.time.ms to set the expire time. 24hr by default as of today.

@klsince klsince changed the title allow to config task expire time, i.e. how often to purge ended tasks from ZK allow to config task expire time Oct 4, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2022

Codecov Report

Merging #9530 (429d5aa) into master (e1aa147) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #9530      +/-   ##
============================================
+ Coverage     69.87%   69.91%   +0.04%     
+ Complexity     5202     5201       -1     
============================================
  Files          1927     1927              
  Lines        102693   102700       +7     
  Branches      15586    15586              
============================================
+ Hits          71760    71807      +47     
+ Misses        25873    25828      -45     
- Partials       5060     5065       +5     
Flag Coverage Δ
integration1 26.06% <75.00%> (+0.08%) ⬆️
integration2 24.58% <75.00%> (+0.05%) ⬆️
unittests1 67.23% <ø> (-0.01%) ⬇️
unittests2 15.57% <75.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...apache/pinot/controller/BaseControllerStarter.java 82.26% <100.00%> (+0.05%) ⬆️
...va/org/apache/pinot/controller/ControllerConf.java 57.14% <100.00%> (+0.16%) ⬆️
...lix/core/minion/PinotHelixTaskResourceManager.java 44.41% <100.00%> (+2.94%) ⬆️
.../common/request/context/predicate/InPredicate.java 87.50% <0.00%> (-6.25%) ⬇️
...nction/DistinctCountBitmapAggregationFunction.java 51.81% <0.00%> (-3.63%) ⬇️
...gregation/function/StUnionAggregationFunction.java 73.52% <0.00%> (-2.95%) ⬇️
...core/operator/docvalsets/TransformBlockValSet.java 59.43% <0.00%> (-2.84%) ⬇️
...nMaxValueBasedSelectionOrderByCombineOperator.java 72.26% <0.00%> (-2.19%) ⬇️
.../org/apache/pinot/core/startree/StarTreeUtils.java 76.28% <0.00%> (-2.07%) ⬇️
...e/pinot/segment/local/io/util/PinotDataBitSet.java 95.62% <0.00%> (-1.46%) ⬇️
... and 17 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@npawar npawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
minor comment: can we be more explicit in the name, that this is the expiry for the ended tasks

@npawar npawar merged commit c79d029 into apache:master Oct 5, 2022
@klsince klsince deleted the config_task_expire_time branch October 5, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants