Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docId and column name to segment read exception #9512

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

KKcorps
Copy link
Contributor

@KKcorps KKcorps commented Oct 2, 2022

No description provided.

@KKcorps KKcorps requested a review from xiangfu0 October 2, 2022 13:16
@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2022

Codecov Report

Merging #9512 (a0acce3) into master (b026d32) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #9512      +/-   ##
============================================
- Coverage     70.00%   69.98%   -0.03%     
- Complexity     4792     4868      +76     
============================================
  Files          1921     1924       +3     
  Lines        102349   102414      +65     
  Branches      15530    15539       +9     
============================================
+ Hits          71651    71674      +23     
- Misses        25636    25676      +40     
- Partials       5062     5064       +2     
Flag Coverage Δ
integration1 26.06% <0.00%> (+0.15%) ⬆️
integration2 24.65% <0.00%> (-0.08%) ⬇️
unittests1 67.24% <0.00%> (-0.07%) ⬇️
unittests2 15.59% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...l/indexsegment/immutable/ImmutableSegmentImpl.java 56.62% <0.00%> (-2.13%) ⬇️
...java/org/apache/pinot/query/planner/QueryPlan.java 22.85% <0.00%> (-77.15%) ⬇️
...ntroller/helix/core/minion/TaskMetricsEmitter.java 34.88% <0.00%> (-51.17%) ⬇️
...he/pinot/segment/local/utils/CustomSerDeUtils.java 35.48% <0.00%> (-14.52%) ⬇️
...g/apache/pinot/query/planner/stage/FilterNode.java 85.71% <0.00%> (-14.29%) ⬇️
.../apache/pinot/query/planner/stage/ProjectNode.java 85.71% <0.00%> (-14.29%) ⬇️
...ore/query/scheduler/resources/ResourceManager.java 84.00% <0.00%> (-12.00%) ⬇️
...pache/pinot/query/planner/stage/TableScanNode.java 88.88% <0.00%> (-11.12%) ⬇️
...che/pinot/query/planner/stage/MailboxSendNode.java 90.90% <0.00%> (-9.10%) ⬇️
.../pinot/query/planner/stage/MailboxReceiveNode.java 90.90% <0.00%> (-9.10%) ⬇️
... and 77 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@navina navina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@xiangfu0 xiangfu0 merged commit 421154f into apache:master Oct 3, 2022
61yao pushed a commit to 61yao/pinot that referenced this pull request Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants