Add query interruption flag check to broker groupby reduction #9499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somandal
reviewed
Sep 29, 2022
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/GroupByDataTableReducer.java
Outdated
Show resolved
Hide resolved
vvivekiyer
reviewed
Sep 29, 2022
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/GroupByDataTableReducer.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #9499 +/- ##
============================================
+ Coverage 63.55% 67.28% +3.73%
+ Complexity 5115 4999 -116
============================================
Files 1862 1421 -441
Lines 99733 74215 -25518
Branches 15212 11850 -3362
============================================
- Hits 63387 49938 -13449
+ Misses 31676 20657 -11019
+ Partials 4670 3620 -1050
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
vvivekiyer
approved these changes
Sep 30, 2022
vvivekiyer
reviewed
Sep 30, 2022
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/GroupByDataTableReducer.java
Outdated
Show resolved
Hide resolved
|
let's try power of 2 batch size once and assess impact of modulo v/s bit shift |
siddharthteotia
approved these changes
Sep 30, 2022
61yao
pushed a commit
to 61yao/pinot
that referenced
this pull request
Oct 3, 2022
…#9499) * add query interruption flag check to broker groupby reduction * add query interruption flag check to broker groupby reduction * add query interruption flag check to broker groupby reduction * add benchmark * tiled loop * add benchmark * Trigger Test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for interruption during broker reduction on groupby results. So that after the timeout the worker threads can be cleaned up timely.