fix null transform bound check #9495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackie-Jiang
approved these changes
Sep 29, 2022
mayankshriv
reviewed
Sep 29, 2022
walterddr
commented
Sep 29, 2022
|
|
||
| protected Map<String, DataSource> _dataSourceMap; | ||
| protected ProjectionBlock _projectionBlock; | ||
| protected static final int NULL_VALUE_MOD = 10; |
There was a problem hiding this comment.
added test. previously this mod is multipler of NUM_ROWS (1000) thus always result in a deterministic pattern. use random to test instead
61yao
pushed a commit
to 61yao/pinot
that referenced
this pull request
Oct 3, 2022
* fix bound check * add test Co-authored-by: Rong Rong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.