Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine the minion task progress api a bit #9482

Merged
merged 2 commits into from
Sep 29, 2022

Conversation

klsince
Copy link
Contributor

@klsince klsince commented Sep 28, 2022

Refine a bit about the API reporting finer grained minion task progress status and bugfix

Copy link
Contributor

@zhtaoxiang zhtaoxiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klsince klsince force-pushed the refine_task_progress_api branch from 703dc33 to 3dd43c5 Compare September 28, 2022 21:28
@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2022

Codecov Report

Merging #9482 (f0a51ff) into master (2daa863) will increase coverage by 34.75%.
The diff coverage is 50.00%.

@@              Coverage Diff              @@
##             master    #9482       +/-   ##
=============================================
+ Coverage     35.09%   69.84%   +34.75%     
- Complexity      189     5140     +4951     
=============================================
  Files          1915     1915               
  Lines        101994   101991        -3     
  Branches      15468    15469        +1     
=============================================
+ Hits          35791    71240    +35449     
+ Misses        63158    25721    -37437     
- Partials       3045     5030     +1985     
Flag Coverage Δ
integration1 25.94% <12.50%> (-0.05%) ⬇️
integration2 24.70% <0.00%> (?)
unittests1 67.09% <ø> (?)
unittests2 15.51% <37.50%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...in/java/org/apache/pinot/spi/utils/StringUtil.java 81.81% <ø> (+81.81%) ⬆️
.../pinot/minion/taskfactory/TaskFactoryRegistry.java 79.41% <33.33%> (ø)
...lix/core/minion/PinotHelixTaskResourceManager.java 41.46% <50.00%> (+1.73%) ⬆️
...che/pinot/minion/event/MinionProgressObserver.java 77.50% <100.00%> (ø)
...roller/helix/core/relocation/SegmentRelocator.java 72.97% <0.00%> (-5.41%) ⬇️
...troller/helix/core/retention/RetentionManager.java 79.03% <0.00%> (-4.84%) ⬇️
...nction/DistinctCountBitmapAggregationFunction.java 49.22% <0.00%> (-4.67%) ⬇️
...r/validation/RealtimeSegmentValidationManager.java 72.97% <0.00%> (-4.06%) ⬇️
...pache/pinot/minion/event/MinionEventObservers.java 89.65% <0.00%> (-1.73%) ⬇️
...controller/helix/core/minion/PinotTaskManager.java 66.56% <0.00%> (-1.47%) ⬇️
... and 1104 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@klsince klsince force-pushed the refine_task_progress_api branch from 3dd43c5 to f0a51ff Compare September 28, 2022 22:35
@jackjlli jackjlli merged commit ae239cd into apache:master Sep 29, 2022
@klsince klsince deleted the refine_task_progress_api branch September 29, 2022 01:41
61yao pushed a commit to 61yao/pinot that referenced this pull request Oct 3, 2022
* refine the minion task progress api a bit

* fix ut
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants