adding optional client payload #9465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 29, 2022 08:50
…nst random unstable sort value
walterddr
force-pushed
the
add_optional_json_payload_client
branch
from
35db343 to
667001c
Compare
| @Nullable SslContext sslContext, ConnectionTimeouts connectionTimeouts, TlsProtocols tlsProtocols) { | ||
| _brokerReadTimeout = connectionTimeouts.getReadTimeoutMs(); | ||
| _headers = headers; | ||
| _scheme = scheme; | ||
| _extraOptionStr = StringUtils.isEmpty(extraOptionStr) ? DEFAULT_EXTRA_QUERY_OPTION_STRING : extraOptionStr; |
There was a problem hiding this comment.
don't we ned to concat the DEFAULT with what user passed in to keep behavior same ?
There was a problem hiding this comment.
yeah I thought about it and wasn't sure if this is a good idea since these 2 options have been in the deprecation process for a while. but good call out
There was a problem hiding this comment.
Ohh yeah. Let's probably ignore then
siddharthteotia
approved these changes
Sep 30, 2022
61yao
pushed a commit
to 61yao/pinot
that referenced
this pull request
Oct 3, 2022
* adding optional client payload * adding stable sort to make sure the result sets are not compared against random unstable sort value Co-authored-by: Rong Rong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently Pinot java client doesn't support optional json payload. adding this as part of the client creation process.