Adaptive Server Selection: Address pending review comments #9462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvivekiyer
force-pushed
the
serverSelectionReviewComments
branch
from
124ac9f to
83a8a29
Compare
|
@Jackie-Jiang please review. |
Codecov Report
@@ Coverage Diff @@
## master #9462 +/- ##
============================================
- Coverage 69.83% 68.62% -1.22%
+ Complexity 5127 4805 -322
============================================
Files 1909 1909
Lines 101749 101749
Branches 15440 15439 -1
============================================
- Hits 71059 69823 -1236
- Misses 25674 26934 +1260
+ Partials 5016 4992 -24
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Jackie-Jiang
approved these changes
Sep 26, 2022
...src/main/java/org/apache/pinot/broker/routing/instanceselector/BalancedInstanceSelector.java
Outdated
Show resolved
Hide resolved
siddharthteotia
changed the title
61yao
pushed a commit
to 61yao/pinot
that referenced
this pull request
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses comments received in #9311 that could not be addressed before the PR got checked in