Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix skip segment logic in MinMaxValueBasedSelectionOrderByCombineOperator #9434

Merged

Conversation

Jackie-Jiang
Copy link
Contributor

#9387 improves the thread usage for combine operator, but it breaks the skipping segment logic in MinMaxValueBasedSelectionOrderByCombineOperator which relies on pre-assign the segments to the thread

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2022

Codecov Report

Merging #9434 (f47ccee) into master (985d0b5) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #9434      +/-   ##
============================================
- Coverage     69.82%   69.82%   -0.01%     
+ Complexity     5095     4715     -380     
============================================
  Files          1889     1889              
  Lines        100851   100856       +5     
  Branches      15328    15329       +1     
============================================
+ Hits          70421    70422       +1     
- Misses        25453    25465      +12     
+ Partials       4977     4969       -8     
Flag Coverage Δ
integration1 26.02% <100.00%> (+0.06%) ⬆️
integration2 24.78% <100.00%> (+0.03%) ⬆️
unittests1 67.12% <82.35%> (+0.04%) ⬆️
unittests2 15.37% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nMaxValueBasedSelectionOrderByCombineOperator.java 73.72% <100.00%> (+0.23%) ⬆️
...data/manager/realtime/DefaultSegmentCommitter.java 0.00% <0.00%> (-80.00%) ⬇️
...er/api/resources/LLCSegmentCompletionHandlers.java 43.56% <0.00%> (-18.82%) ⬇️
...data/manager/realtime/SegmentCommitterFactory.java 88.23% <0.00%> (-11.77%) ⬇️
...transform/function/IsNotNullTransformFunction.java 67.85% <0.00%> (-7.15%) ⬇️
...altime/ServerSegmentCompletionProtocolHandler.java 51.88% <0.00%> (-6.61%) ⬇️
...tream/kafka20/server/KafkaDataServerStartable.java 72.91% <0.00%> (-6.25%) ⬇️
...nction/DistinctCountBitmapAggregationFunction.java 49.74% <0.00%> (-5.70%) ⬇️
...roller/helix/core/relocation/SegmentRelocator.java 72.97% <0.00%> (-5.41%) ⬇️
...gregation/function/StUnionAggregationFunction.java 73.52% <0.00%> (-2.95%) ⬇️
... and 27 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@siddharthteotia siddharthteotia merged commit b043dd8 into apache:master Sep 20, 2022
@Jackie-Jiang Jackie-Jiang deleted the fix_min_max_combine_operator branch September 20, 2022 17:53
61yao pushed a commit to 61yao/pinot that referenced this pull request Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants