Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[multistage] add cast function #9384

Merged
merged 4 commits into from
Sep 13, 2022
Merged

Conversation

walterddr
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2022

Codecov Report

Merging #9384 (69d05b4) into master (c5a2ec5) will decrease coverage by 25.69%.
The diff coverage is 64.70%.

@@              Coverage Diff              @@
##             master    #9384       +/-   ##
=============================================
- Coverage     62.80%   37.11%   -25.70%     
+ Complexity     4569      194     -4375     
=============================================
  Files          1873     1885       +12     
  Lines        100061   100429      +368     
  Branches      15241    15280       +39     
=============================================
- Hits          62848    37270    -25578     
- Misses        32502    60052    +27550     
+ Partials       4711     3107     -1604     
Flag Coverage Δ
integration1 26.10% <0.00%> (+0.07%) ⬆️
integration2 24.85% <0.00%> (+0.01%) ⬆️
unittests1 ?
unittests2 15.37% <64.70%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...che/pinot/query/planner/logical/RexExpression.java 74.35% <64.70%> (-1.84%) ⬇️
...in/java/org/apache/pinot/spi/utils/BytesUtils.java 0.00% <0.00%> (-100.00%) ⬇️
.../java/org/apache/pinot/spi/utils/BooleanUtils.java 0.00% <0.00%> (-100.00%) ⬇️
...java/org/apache/pinot/spi/trace/BaseRecording.java 0.00% <0.00%> (-100.00%) ⬇️
...java/org/apache/pinot/spi/trace/NoOpRecording.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/config/table/FSTType.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/config/user/RoleType.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/data/MetricFieldSpec.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/utils/NullValueUtils.java 0.00% <0.00%> (-100.00%) ⬇️
...java/org/apache/pinot/common/tier/TierFactory.java 0.00% <0.00%> (-100.00%) ⬇️
... and 1234 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@walterddr walterddr marked this pull request as ready for review September 12, 2022 20:25
@Jackie-Jiang Jackie-Jiang added the multi-stage Related to the multi-stage query engine label Sep 13, 2022
@siddharthteotia
Copy link
Contributor

@walterddr can you rebase please

@walterddr walterddr merged commit ff2a333 into apache:master Sep 13, 2022
@walterddr walterddr deleted the pr_add_cast branch December 6, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multi-stage Related to the multi-stage query engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants