Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[multistage][feature] Support a join b using(col) #9373

Merged
merged 1 commit into from
Sep 10, 2022

Conversation

61yao
Copy link
Contributor

@61yao 61yao commented Sep 10, 2022

Turns out this feature is already supported. Added a test to show that and increase test coverage.

@61yao
Copy link
Contributor Author

61yao commented Sep 10, 2022

@walterddr

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2022

Codecov Report

Merging #9373 (d1e1189) into master (334c978) will decrease coverage by 1.33%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #9373      +/-   ##
============================================
- Coverage     69.76%   68.42%   -1.34%     
- Complexity     4704     5070     +366     
============================================
  Files          1882     1884       +2     
  Lines        100155   100282     +127     
  Branches      15226    15253      +27     
============================================
- Hits          69874    68622    -1252     
- Misses        25344    26730    +1386     
+ Partials       4937     4930       -7     
Flag Coverage Δ
integration1 26.06% <ø> (-0.14%) ⬇️
integration2 ?
unittests1 66.94% <ø> (+0.03%) ⬆️
unittests2 15.31% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t/core/plan/StreamingInstanceResponsePlanNode.java 0.00% <0.00%> (-100.00%) ⬇️
...ore/operator/streaming/StreamingResponseUtils.java 0.00% <0.00%> (-100.00%) ⬇️
...server/starter/helix/SegmentReloadStatusValue.java 0.00% <0.00%> (-100.00%) ⬇️
.../operator/blocks/results/MetadataResultsBlock.java 0.00% <0.00%> (-100.00%) ⬇️
...ager/realtime/PeerSchemeSplitSegmentCommitter.java 0.00% <0.00%> (-100.00%) ⬇️
...urces/ServerReloadControllerJobStatusResponse.java 0.00% <0.00%> (-100.00%) ⬇️
...ator/streaming/StreamingSelectionOnlyOperator.java 0.00% <0.00%> (-90.00%) ⬇️
...he/pinot/core/plan/StreamingSelectionPlanNode.java 0.00% <0.00%> (-88.89%) ⬇️
...che/pinot/common/auth/StaticTokenAuthProvider.java 0.00% <0.00%> (-87.50%) ⬇️
...roker/requesthandler/GrpcBrokerRequestHandler.java 0.00% <0.00%> (-86.96%) ⬇️
... and 166 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@walterddr walterddr merged commit f796de4 into apache:master Sep 10, 2022
@Jackie-Jiang Jackie-Jiang added the multi-stage Related to the multi-stage query engine label Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multi-stage Related to the multi-stage query engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants