Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pom to use pinot-common-jdk8 for pinot-connector jkd8 java client #9353

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

somandal
Copy link
Contributor

@somandal somandal commented Sep 9, 2022

This PR fixes the pinot-common module added as part of PR #9351 to use pinot-common-jdk8 instead of pinot-common.

cc @xiangfu0 @siddharthteotia

@somandal somandal changed the title Fix pom to use pinot-common-jdk8 for pinot-connector presto Fix pom to use pinot-common-jdk8 for pinot-connector jkd8 java client Sep 9, 2022
@xiangfu0 xiangfu0 merged commit 33dc520 into apache:master Sep 9, 2022
@xiangfu0
Copy link
Contributor

xiangfu0 commented Sep 9, 2022

Thanks for your quick turnaround!

@somandal somandal deleted the fix-jdk8-build-2 branch September 9, 2022 06:12
@somandal somandal restored the fix-jdk8-build-2 branch September 9, 2022 06:15
@somandal
Copy link
Contributor Author

somandal commented Sep 9, 2022

@xiangfu0
Sorry I forgot to mention I'm still building this locally. I've run into this issue:

[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project pinot-java-client-jdk8: Could not resolve dependencies for project org.apache.pinot:pinot-java-client-jdk8:jar:0.12.0-SNAPSHOT: Could not find artifact org.apache.pinot:pinot-common-jkd8:jar:0.12.0-SNAPSHOT in apache.snapshots (https://repository.apache.org/snapshots) -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <args> -rf :pinot-java-client-jdk8

How to resolve the above? We should probably revert this change and understand why the dependency doesn't seem to get resolved for org.apache.pinot:pinot-common-jkd8:jar:0.12.0-SNAPSHOT. perhaps no such module is built?

Oddly in the build logs I do see pinot-comon-jdk8:

[INFO] --- maven-install-plugin:2.5.2:install (default-install) @ pinot-common-jdk8 ---
[INFO] Installing /Users/somandal/pinot/pinot/pinot-connectors/prestodb-pinot-dependencies/pinot-common-jdk8/target/pinot-common-jdk8-0.12.0-SNAPSHOT.jar to /Users/somandal/.m2/repository/org/apache/pinot/pinot-common-jdk8/0.12.0-SNAPSHOT/pinot-common-jdk8-0.12.0-SNAPSHOT.jar
[INFO] Installing /Users/somandal/pinot/pinot/pinot-connectors/prestodb-pinot-dependencies/pinot-common-jdk8/pom.xml to /Users/somandal/.m2/repository/org/apache/pinot/pinot-common-jdk8/0.12.0-SNAPSHOT/pinot-common-jdk8-0.12.0-SNAPSHOT.pom
[INFO] Installing /Users/somandal/pinot/pinot/pinot-connectors/prestodb-pinot-dependencies/pinot-common-jdk8/target/pinot-common-jdk8-0.12.0-SNAPSHOT-tests.jar to /Users/somandal/.m2/repository/org/apache/pinot/pinot-common-jdk8/0.12.0-SNAPSHOT/pinot-common-jdk8-0.12.0-SNAPSHOT-tests.jar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants