Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow hiding pinot broker swagger UI by config #9343

Merged
merged 2 commits into from
Sep 8, 2022

Conversation

dongxiaoman
Copy link
Contributor

Description

Add an extra property in broker so we can hide Broker Swagger UI completely.
This is following the style in PR #7341 that can hide server Swagger UI

Release Notes

  • Introduce pinot.broker.swagger.enabled=true property to broker so we can hide broker swagger UI on demand

@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2022

Codecov Report

Merging #9343 (83fc048) into master (334c978) will decrease coverage by 44.84%.
The diff coverage is 60.00%.

@@              Coverage Diff              @@
##             master    #9343       +/-   ##
=============================================
- Coverage     69.76%   24.92%   -44.85%     
+ Complexity     4704       53     -4651     
=============================================
  Files          1882     1870       -12     
  Lines        100155    99825      -330     
  Branches      15226    15193       -33     
=============================================
- Hits          69874    24881    -44993     
- Misses        25344    72418    +47074     
+ Partials       4937     2526     -2411     
Flag Coverage Δ
integration1 ?
integration2 24.92% <60.00%> (+0.04%) ⬆️
unittests1 ?
unittests2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...va/org/apache/pinot/spi/utils/CommonConstants.java 0.00% <ø> (-27.70%) ⬇️
...pinot/broker/broker/BrokerAdminApiApplication.java 85.00% <60.00%> (-2.50%) ⬇️
...in/java/org/apache/pinot/spi/utils/BytesUtils.java 0.00% <0.00%> (-100.00%) ⬇️
.../java/org/apache/pinot/spi/utils/BooleanUtils.java 0.00% <0.00%> (-100.00%) ⬇️
...java/org/apache/pinot/spi/trace/BaseRecording.java 0.00% <0.00%> (-100.00%) ⬇️
...java/org/apache/pinot/spi/trace/NoOpRecording.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/config/table/FSTType.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/config/user/RoleType.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/data/MetricFieldSpec.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/utils/NullValueUtils.java 0.00% <0.00%> (-100.00%) ⬇️
... and 1370 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xiangfu0 xiangfu0 self-requested a review September 8, 2022 01:49
@dongxiaoman dongxiaoman requested a review from xiangfu0 September 8, 2022 17:19
@Jackie-Jiang Jackie-Jiang merged commit 9d76fcf into apache:master Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants