Fix thrift deserializer thread safety issue #9299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saurabhd336
force-pushed
the
thriftDeserializerFix
branch
from
83695ec to
024d8d9
Compare
Codecov Report
@@ Coverage Diff @@
## master #9299 +/- ##
=============================================
- Coverage 69.82% 35.00% -34.83%
+ Complexity 4696 183 -4513
=============================================
Files 1873 1873
Lines 99623 99623
Branches 15146 15146
=============================================
- Hits 69564 34871 -34693
- Misses 25118 61789 +36671
+ Partials 4941 2963 -1978
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
klsince
approved these changes
Aug 30, 2022
| @@ -73,7 +73,7 @@ public class InstanceRequestHandler extends SimpleChannelInboundHandler<ByteBuf> | |||
| private static final int SLOW_QUERY_LATENCY_THRESHOLD_MS = 100; | |||
|
|
|||
| private final String _instanceName; | |||
| private final TDeserializer _deserializer; | |||
There was a problem hiding this comment.
👍 good catch! perhaps a comment that this is not thread safe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InstanceRequestHandler is being shared across multiple netty channels (and potentially different event loop threads), therefore it's
channelRead0function needs to be thread safe.TDeserializerinstances are not thread safe hence each thread needs a ThreadLocal copy of it.