Fix transformation to string for BOOLEAN and TIMESTAMP #9287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackie-Jiang
force-pushed
the
simplify_cast
branch
from
eaef795 to
e2b48b2
Compare
xiangfu0
reviewed
Aug 27, 2022
| longValues = transformToLongValuesSV(projectionBlock); | ||
| for (int i = 0; i < length; i++) { | ||
| _stringValuesSV[i] = new Timestamp(longValues[i]).toString(); | ||
| } |
There was a problem hiding this comment.
We don't really need break for default branch. Changed it to if-else branches for clarity
There was a problem hiding this comment.
Oh, we do have linter check for that lol
xiangfu0
reviewed
Aug 27, 2022
...e/src/main/java/org/apache/pinot/core/operator/transform/function/BaseTransformFunction.java
Outdated
Show resolved
Hide resolved
Jackie-Jiang
force-pushed
the
simplify_cast
branch
from
e2b48b2 to
0583e84
Compare
Codecov Report
@@ Coverage Diff @@
## master #9287 +/- ##
=============================================
- Coverage 68.60% 24.82% -43.79%
+ Complexity 5007 53 -4954
=============================================
Files 1867 1855 -12
Lines 99631 99217 -414
Branches 15150 15126 -24
=============================================
- Hits 68351 24627 -43724
- Misses 26362 72105 +45743
+ Partials 4918 2485 -2433
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Jackie-Jiang
force-pushed
the
simplify_cast
branch
2 times, most recently
from
221852a to
e5d6462
Compare
Jackie-Jiang
force-pushed
the
simplify_cast
branch
from
e5d6462 to
b6270d8
Compare
xiangfu0
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
BOOLEANandTIMESTAMP(logical types), when reading them as string, we should use the logical type to returntrue,2022-02-02 00:00:00.000instead of the int/long value.With the fix in
BaseTransformFunction, theCASTtransform function can be greatly simplified.