Add metrics to track controller segment download and upload requests in progress #9258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gviedma
changed the title
gviedma
force-pushed
the
track_controller_inflight_downloads_uploads
branch
2 times, most recently
from
b3d67d5 to
166f5bb
Compare
gviedma
changed the title
gviedma
changed the title
gviedma
changed the title
gviedma
force-pushed
the
track_controller_inflight_downloads_uploads
branch
2 times, most recently
from
ddab727 to
7c2ae1a
Compare
Codecov Report
@@ Coverage Diff @@
## master #9258 +/- ##
============================================
+ Coverage 68.75% 69.96% +1.20%
- Complexity 4755 5011 +256
============================================
Files 1859 1860 +1
Lines 99129 99152 +23
Branches 15077 15080 +3
============================================
+ Hits 68161 69371 +1210
+ Misses 26076 24864 -1212
- Partials 4892 4917 +25
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Jackie-Jiang
added
release-notes
mcvsubbu
reviewed
Aug 22, 2022
| MISSING_CONSUMING_SEGMENT_MAX_DURATION_MINUTES("missingSegmentsMaxDurationInMinutes", false), | ||
|
|
||
| // Number of in progress segment downloads | ||
| CONTROLLER_SEGMENT_DOWNLOADS_IN_PROGRESS_COUNT("segmentDownloadsInProgressCount", true), |
There was a problem hiding this comment.
Maybe remove CONTROLLER_ prefix? It is in ControllerGauge, emitted by the controller, so we are fine to remove the prefix? Also, maybe remove the _COUNT suffix also?
Metric names are getting long....
There was a problem hiding this comment.
Good point, I've dropped both the CONTROLLER_ prefix and the _COUNT suffix for readability.
I have also tagged the segmentUpload method in LLCSegmentCompletionHandlers for tracking.
gviedma
force-pushed
the
track_controller_inflight_downloads_uploads
branch
from
7c2ae1a to
50b6063
Compare
mcvsubbu
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change tracks the number of in progress segment download and upload requests currently being processed by the controller via their respective Gauge metrics segmentDownloadsInProgress and segmentUploadsInProgress. These two metrics are useful to track the number of in-flight operations in large clusters, where a large number of concurrent uploads/downloads may bring down a shared controller.
This change also introduces a generic JAX-RS annotation-based mechanism that can be reused to track in-flight request metrics of other types in the future. See InflightRequestMetricsInterceptor.