Fix bug with logging request headers

[abhs50]

This PR refactors code to not assume RequestIdentity of type HttpRequestIdentity only. Moving getClientIp to RequestIdentity forces all subclasses to have its own overridden implementation or rely on default.

#9194

[codecov-commenter]

Codecov Report

Merging #9247 (1763817) into master (42e597d) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #9247      +/-   ##
============================================
+ Coverage     69.96%   69.98%   +0.01%     
+ Complexity     5005     4767     -238     
============================================
  Files          1852     1859       +7     
  Lines         98848    99126     +278     
  Branches      15039    15076      +37     
============================================
+ Hits          69159    69369     +210     
- Misses        24809    24864      +55     
- Partials       4880     4893      +13     

Flag	Coverage Δ
integration1	26.27% <0.00%> (+0.04%)	⬆️
integration2	24.95% <0.00%> (+0.18%)	⬆️
unittests1	67.13% <ø> (+0.03%)	⬆️
unittests2	15.34% <0.00%> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...apache/pinot/broker/api/HttpRequesterIdentity.java	28.57% <0.00%> (-57.15%)	⬇️
...org/apache/pinot/broker/api/RequesterIdentity.java	50.00% <0.00%> (-50.00%)	⬇️
...roker/requesthandler/BaseBrokerRequestHandler.java	72.33% <ø> (-0.24%)	⬇️
...va/org/apache/pinot/spi/utils/CommonConstants.java	27.69% <ø> (ø)
...r/requesthandler/BrokerRequestHandlerDelegate.java	52.50% <0.00%> (-28.46%)	⬇️
...tream/kafka20/server/KafkaDataServerStartable.java	72.91% <0.00%> (-23.96%)	⬇️
...pinot/broker/api/resources/PinotClientRequest.java	43.28% <0.00%> (-15.05%)	⬇️
...inot/controller/api/access/AccessControlUtils.java	63.63% <0.00%> (-10.28%)	⬇️
...rg/apache/pinot/spi/config/table/UpsertConfig.java	73.17% <0.00%> (-6.83%)	⬇️
.../filter/predicate/InPredicateEvaluatorFactory.java	77.60% <0.00%> (-4.81%)	⬇️
... and 88 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[vvivekiyer]

LGTM.