-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refine query cancel resp msg #9242
Conversation
6f061d6
to
e24edf6
Compare
Codecov Report
@@ Coverage Diff @@
## master #9242 +/- ##
============================================
- Coverage 69.93% 67.10% -2.83%
+ Complexity 5009 4816 -193
============================================
Files 1860 1382 -478
Lines 99185 72022 -27163
Branches 15082 11533 -3549
============================================
- Hits 69367 48333 -21034
+ Misses 24905 20176 -4729
+ Partials 4913 3513 -1400
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
055950a
to
7d0f7ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to handle the exception in SelectionOrderByCombineOperator
pinot-common/src/main/java/org/apache/pinot/common/exception/QueryException.java
Outdated
Show resolved
Hide resolved
pinot-core/src/main/java/org/apache/pinot/core/operator/combine/BaseCombineOperator.java
Outdated
Show resolved
Hide resolved
9d282c3
to
d7af8d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise
pinot-core/src/main/java/org/apache/pinot/core/operator/combine/BaseCombineOperator.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/org/apache/pinot/core/operator/combine/SelectionOrderByCombineOperator.java
Outdated
Show resolved
Hide resolved
pinot-core/src/main/java/org/apache/pinot/core/plan/CombinePlanNode.java
Show resolved
Hide resolved
pinot-core/src/main/java/org/apache/pinot/core/transport/InstanceRequestHandler.java
Outdated
Show resolved
Hide resolved
pinot-core/src/main/java/org/apache/pinot/core/transport/InstanceRequestHandler.java
Outdated
Show resolved
Hide resolved
pinot-core/src/main/java/org/apache/pinot/core/transport/InstanceRequestHandler.java
Outdated
Show resolved
Hide resolved
pinot-core/src/main/java/org/apache/pinot/core/query/scheduler/QueryScheduler.java
Show resolved
Hide resolved
deebbef
to
8948cb4
Compare
8948cb4
to
a23db86
Compare
a23db86
to
d4e2c4b
Compare
This PR mainly refines the query cancel resp msg, by defining some explicit query cancel error code and msg, instead of bubbling up the Executor's CancellationException.
Also moves the query tracking mechanism for query cancellation from QueryScheduler to InstanceRequestHandler to be less likely to be overwritten by subclasses, and be more consistent with the logic in BaseBrokerRequestHandler.