Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force commit consuming segments #9197

Merged
merged 2 commits into from
Aug 29, 2022
Merged

Force commit consuming segments #9197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94ccacb
Reset consumption
sajjad-moradi Aug 10, 2022
350a4c8
resetConsumption -> forceCommit
sajjad-moradi Aug 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions ...r/src/main/java/org/apache/pinot/controller/api/resources/PinotRealtimeTableResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,26 @@ public Response resumeConsumption(
}
}

@POST
@Path("/tables/{tableName}/forceCommit")
@ApiOperation(value = "Force commit the current consuming segments",
notes = "Force commit the current segments in consuming state and restart consumption. "
+ "This should be used after schema/table config changes. "
+ "Please note that this is an asynchronous operation, "
+ "and 200 response does not mean it has actually been done already")
public Response forceCommit(
@ApiParam(value = "Name of the table", required = true) @PathParam("tableName") String tableName) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest adding an optional segment so that we only force commit one segment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have partition level pausing. I know this endpoint is a bit different than pause/resume, but let me think about it a bit and maybe we can come up with a way for partition leve operation on all endpoints in this class.

String tableNameWithType = TableNameBuilder.REALTIME.tableNameWithType(tableName);
validate(tableNameWithType);
try {
_pinotLLCRealtimeSegmentManager.forceCommit(tableNameWithType);
return Response.ok().build();
} catch (Exception e) {
throw new ControllerApplicationException(LOGGER, e.getMessage(), Response.Status.INTERNAL_SERVER_ERROR, e);
}
}


@GET
@Path("/tables/{tableName}/pauseStatus")
@Produces(MediaType.APPLICATION_JSON)
Expand Down
9 changes: 9 additions & 0 deletions .../java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1420,6 +1420,15 @@ public void uploadToDeepStoreIfMissing(TableConfig tableConfig, List<SegmentZKMe
}
}

/**
* Force commit the current segments in consuming state and restart consumption
*/
public void forceCommit(String tableNameWithType) {
IdealState idealState = getIdealState(tableNameWithType);
Set<String> consumingSegments = findConsumingSegments(idealState);
sendForceCommitMessageToServers(tableNameWithType, consumingSegments);
}

/**
* Pause consumption on a table by
* 1) setting "isTablePaused" in ideal states to true and
Expand Down