-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for IAM role based credentials in Kinesis Plugin #9071
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9071 +/- ##
============================================
- Coverage 70.09% 63.62% -6.47%
+ Complexity 4741 4718 -23
============================================
Files 1831 1784 -47
Lines 96428 94897 -1531
Branches 14413 14382 -31
============================================
- Hits 67591 60379 -7212
- Misses 24169 30184 +6015
+ Partials 4668 4334 -334
Flags with carried forward coverage won't be shown. Click here to find out more.
|
7d7bfe3
to
a186996
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to add some unit tests for the configs validation ?
lgtm!
...estion/pinot-kinesis/src/main/java/org/apache/pinot/plugin/stream/kinesis/KinesisConfig.java
Show resolved
Hide resolved
a186996
to
59f3f1a
Compare
I planned to add tests in Kinesis integration but unfortunately the localstack IAM service doesn't work as expected and security token fetched from it is always invalid. |
Ah I see. I don't think we need localstack. I just meant a quick unit test for the thanks for working on this! |
Please tag the PR with |
Currently, Kinesis plugin only support DefaultCredentialsProvider but doesn't support IAM role based provider. The PR adds support for this feature.
Supported Configs
true
to enable role based access, default: falsetrue