-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding pinot file system command #8659
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9680bfe
to
538a1d3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8659 +/- ##
============================================
+ Coverage 70.32% 70.37% +0.05%
+ Complexity 4418 4347 -71
============================================
Files 1693 1693
Lines 88309 88309
Branches 13212 13212
============================================
+ Hits 62104 62149 +45
+ Misses 21921 21876 -45
Partials 4284 4284
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fa20d5c
to
2fffb23
Compare
Jackie-Jiang
reviewed
May 9, 2022
pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/FileSystemCommand.java
Outdated
Show resolved
Hide resolved
pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/FileSystemCommand.java
Outdated
Show resolved
Hide resolved
pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/FileSystemCommand.java
Outdated
Show resolved
Hide resolved
pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/FileSystemCommand.java
Outdated
Show resolved
Hide resolved
pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/FileSystemCommand.java
Outdated
Show resolved
Hide resolved
pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/FileSystemCommand.java
Outdated
Show resolved
Hide resolved
62fe5de
to
7498fa0
Compare
walterddr
approved these changes
May 10, 2022
pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/filesystem/ListFiles.java
Show resolved
Hide resolved
debd54f
to
78e3e4f
Compare
78e3e4f
to
35187ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Pinot FS command into toolings for quickly testing if the filesystem configs and settings credentials are correct. Also, users can perform some simple actions if needed.
Usage:
There is also a separate script for it:
Currently, supported sub-command operations are coming from PinotFS interfaces:
Default loaded PinotFS are
org.apache.pinot.spi.filesystem.LocalPinotFS
andorg.apache.pinot.plugin.filesystem.S3PinotFS
if scheme is not registered by the config file.Example:
List files recursively on s3 when AWS is configured:
List files recursively on s3 with the pinot fs config:
The content of
fs.conf
will be deserailize toorg.apache.pinot.spi.ingestion.batch.spec.PinotFSSpec
Examples of no access for s3: