add segment size metric on segment push #8387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -69,6 +69,10 @@ | |||
| // Estimated size of offline table | |||
| OFFLINE_TABLE_ESTIMATED_SIZE("OfflineTableEstimatedSize", false), | |||
|
|
|||
| // Size of an uploaded offline segment | |||
| OFFLINE_SEGMENT_SIZE("OfflineSegmentSize", false), | |||
There was a problem hiding this comment.
Let's name it LAST_PUSHED_SEGMENT_SIZE to be more specific
added. let me know if it's sufficient, please?
that's ok for us as we can aggregate the metric across dimension that do not include the controller host. any concerns on your end? |
Jackie-Jiang
added
the
release-notes
Jackie-Jiang
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an offline segment size metric only when a new segment is pushed. this is stored as a gauge and based on table name. This is useful to build detectors in case:
I tested this by deploying this change to one of our clusters, manually uploading a CSV file, and observing the metric in our metrics platform.
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
backward-incompat, and complete the section below on Release Notes)Does this PR fix a zero-downtime upgrade introduced earlier?
backward-incompat, and complete the section below on Release Notes)Does this PR otherwise need attention when creating release notes? Things to consider:
release-notesand complete the section on Release Notes)Release Notes
This adds a metric for the last pushed segment size in bytes after the segment is successfully pushed.
Documentation