Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Presto pinot driver] Adding NoopPinotMetricFactory and corresponding changes #8270

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

xiangfu0
Copy link
Contributor

@xiangfu0 xiangfu0 commented Mar 1, 2022

Description

Create NoopPinotMetricFactory for PinotScatterGatherQueryClient to bypass the requirement for pinot-yammer runtime dependency.

Upgrade Notes

Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

  • Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

  • Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

  • New configuration options
  • Deprecation of configurations
  • Signature changes to public methods/interfaces
  • New plugins added or old plugins removed
  • Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes

Documentation

@xiangfu0 xiangfu0 force-pushed the adding_noop_metrics branch 3 times, most recently from a7de902 to 8386f54 Compare March 1, 2022 22:41
@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2022

Codecov Report

Merging #8270 (775ac8a) into master (1c4512e) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8270      +/-   ##
============================================
- Coverage     70.81%   70.74%   -0.08%     
+ Complexity     4244     4241       -3     
============================================
  Files          1631     1631              
  Lines         85454    85454              
  Branches      12877    12877              
============================================
- Hits          60515    60455      -60     
- Misses        20758    20824      +66     
+ Partials       4181     4175       -6     
Flag Coverage Δ
integration1 28.91% <ø> (+<0.01%) ⬆️
integration2 27.58% <ø> (-0.10%) ⬇️
unittests1 66.92% <ø> (-0.05%) ⬇️
unittests2 14.16% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...data/manager/realtime/DefaultSegmentCommitter.java 0.00% <0.00%> (-80.00%) ⬇️
...a/manager/realtime/RealtimeSegmentDataManager.java 50.00% <0.00%> (-25.00%) ⬇️
...ller/helix/core/minion/TaskTypeMetricsUpdater.java 80.00% <0.00%> (-20.00%) ⬇️
...er/api/resources/LLCSegmentCompletionHandlers.java 43.56% <0.00%> (-18.82%) ⬇️
...nt/local/startree/v2/store/StarTreeDataSource.java 40.00% <0.00%> (-13.34%) ⬇️
...data/manager/realtime/SegmentCommitterFactory.java 88.23% <0.00%> (-11.77%) ⬇️
...altime/ServerSegmentCompletionProtocolHandler.java 51.42% <0.00%> (-6.67%) ⬇️
...core/startree/operator/StarTreeFilterOperator.java 87.41% <0.00%> (-5.60%) ⬇️
...ot/segment/local/startree/OffHeapStarTreeNode.java 72.22% <0.00%> (-5.56%) ⬇️
...pache/pinot/core/query/optimizer/filter/Range.java 95.91% <0.00%> (-4.09%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c4512e...775ac8a. Read the comment docs.

@xiangfu0 xiangfu0 force-pushed the adding_noop_metrics branch from 8386f54 to 775ac8a Compare March 1, 2022 23:16
@xiangfu0 xiangfu0 requested a review from Jackie-Jiang March 1, 2022 23:27
@xiangfu0 xiangfu0 changed the title Adding NoopPinotMetricFactory and corresponding changes [Presto pinot driver] Adding NoopPinotMetricFactory and corresponding changes Mar 2, 2022
@xiangfu0 xiangfu0 merged commit fd9c58a into apache:master Mar 2, 2022
@xiangfu0 xiangfu0 deleted the adding_noop_metrics branch March 2, 2022 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants