Bugfix for order-by all sorted optimization #8263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackie-Jiang
force-pushed
the
order_by_all_sorted
branch
from
02eb83d to
90a53d8
Compare
Jackie-Jiang
commented
Feb 28, 2022
| @@ -56,14 +56,16 @@ public SelectionPlanNode(IndexSegment indexSegment, QueryContext queryContext) { | |||
| if (orderByExpressions == null) { | |||
| // Selection only | |||
| TransformOperator transformOperator = new TransformPlanNode(_indexSegment, _queryContext, expressions, | |||
| Math.min(limit + _queryContext.getOffset(), DocIdSetPlanNode.MAX_DOC_PER_CALL)).run(); | |||
| Math.min(limit, DocIdSetPlanNode.MAX_DOC_PER_CALL)).run(); | |||
There was a problem hiding this comment.
Without order-by, should scan limit records
Jackie-Jiang
commented
Feb 28, 2022
| if (isAllOrderByColumnsSorted(orderByExpressions)) { | ||
| // All order-by columns are sorted, no need to sort the records | ||
| TransformOperator transformOperator = new TransformPlanNode(_indexSegment, _queryContext, expressions, | ||
| Math.min(limit + _queryContext.getOffset(), DocIdSetPlanNode.MAX_DOC_PER_CALL)).run(); |
There was a problem hiding this comment.
With order-by, should scan limit + offset records
Jackie-Jiang
commented
Feb 28, 2022
| @@ -101,14 +103,12 @@ public SelectionPlanNode(IndexSegment indexSegment, QueryContext queryContext) { | |||
| * @return true is all columns in order by clause are sorted . False otherwise | |||
| */ | |||
| private boolean isAllOrderByColumnsSorted(List<OrderByExpressionContext> orderByExpressions) { | |||
| int numOrderByExpressions = orderByExpressions.size(); | |||
| for (int i = 0; i < numOrderByExpressions; i++) { | |||
| OrderByExpressionContext expressionContext = orderByExpressions.get(0); | |||
There was a problem hiding this comment.
orderByExpressions.get(0) is wrong, and can cause false positive
Codecov Report
@@ Coverage Diff @@
## master #8263 +/- ##
=============================================
- Coverage 64.06% 14.17% -49.89%
+ Complexity 4246 81 -4165
=============================================
Files 1586 1586
Lines 83399 83547 +148
Branches 12641 12667 +26
=============================================
- Hits 53427 11842 -41585
- Misses 26129 70817 +44688
+ Partials 3843 888 -2955
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
xiangfu0
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.