Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise sorteddociditerationorder #8213

Conversation

richardstartin
Copy link
Member

No description provided.

@richardstartin richardstartin force-pushed the optimise-sorteddociditerationorder branch from 634553c to a822d89 Compare February 16, 2022 23:52
@richardstartin richardstartin force-pushed the optimise-sorteddociditerationorder branch from a822d89 to ce76e15 Compare February 16, 2022 23:53
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2022

Codecov Report

Merging #8213 (ce76e15) into master (916d807) will decrease coverage by 7.19%.
The diff coverage is 14.28%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8213      +/-   ##
============================================
- Coverage     71.02%   63.83%   -7.20%     
+ Complexity     4314     4232      -82     
============================================
  Files          1626     1614      -12     
  Lines         84929    84580     -349     
  Branches      12783    12745      -38     
============================================
- Hits          60325    53994    -6331     
- Misses        20462    26656    +6194     
+ Partials       4142     3930     -212     
Flag Coverage Δ
integration1 28.71% <0.00%> (-0.08%) ⬇️
integration2 27.45% <0.00%> (+0.04%) ⬆️
unittests1 67.38% <14.28%> (-0.01%) ⬇️
unittests2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...local/indexsegment/mutable/MutableSegmentImpl.java 58.69% <14.28%> (-0.39%) ⬇️
...pinot/controller/recommender/io/ConfigManager.java 0.00% <0.00%> (-100.00%) ⬇️
...troller/recommender/io/metadata/FieldMetadata.java 0.00% <0.00%> (-100.00%) ⬇️
...roller/recommender/rules/impl/BloomFilterRule.java 0.00% <0.00%> (-100.00%) ⬇️
...oller/api/resources/PinotControllerAppConfigs.java 0.00% <0.00%> (-100.00%) ⬇️
...ler/recommender/data/generator/BytesGenerator.java 0.00% <0.00%> (-100.00%) ⬇️
...er/recommender/io/metadata/SchemaWithMetaData.java 0.00% <0.00%> (-100.00%) ⬇️
...r/recommender/rules/impl/AggregateMetricsRule.java 0.00% <0.00%> (-100.00%) ⬇️
.../recommender/exceptions/InvalidInputException.java 0.00% <0.00%> (-100.00%) ⬇️
.../recommender/rules/io/configs/PartitionConfig.java 0.00% <0.00%> (-100.00%) ⬇️
... and 228 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 916d807...ce76e15. Read the comment docs.

@richardstartin richardstartin merged commit d047e7b into apache:master Feb 17, 2022
xiangfu0 pushed a commit to xiangfu0/pinot that referenced this pull request Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants