Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing Reported Size and Estimated Size in human readable format in UI #8199

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Showing Reported Size and Estimated Size in human readable format in UI #8199

merged 1 commit into from
Feb 14, 2022

Conversation

shahsank3t
Copy link
Contributor

Description

This PR fixes #8198

image

image

@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2022

Codecov Report

Merging #8199 (229df34) into master (bad7106) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8199      +/-   ##
============================================
- Coverage     71.33%   71.32%   -0.02%     
  Complexity     4308     4308              
============================================
  Files          1623     1623              
  Lines         84365    84365              
  Branches      12657    12657              
============================================
- Hits          60183    60174       -9     
- Misses        20050    20063      +13     
+ Partials       4132     4128       -4     
Flag Coverage Δ
integration1 28.77% <ø> (-0.07%) ⬇️
integration2 27.58% <ø> (-0.02%) ⬇️
unittests1 67.87% <ø> (+<0.01%) ⬆️
unittests2 14.25% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...he/pinot/segment/local/segment/store/IndexKey.java 70.00% <0.00%> (-5.00%) ⬇️
...nction/DistinctCountBitmapAggregationFunction.java 49.22% <0.00%> (-4.15%) ⬇️
...apache/pinot/controller/api/upload/ZKOperator.java 74.80% <0.00%> (-1.58%) ⬇️
...g/apache/pinot/common/utils/helix/HelixHelper.java 45.14% <0.00%> (-0.98%) ⬇️
...ata/manager/realtime/RealtimeTableDataManager.java 68.27% <0.00%> (-0.81%) ⬇️
...core/startree/operator/StarTreeFilterOperator.java 85.31% <0.00%> (-0.70%) ⬇️
...manager/realtime/LLRealtimeSegmentDataManager.java 70.44% <0.00%> (-0.66%) ⬇️
...va/org/apache/pinot/controller/ControllerConf.java 58.70% <0.00%> (-0.41%) ⬇️
...a/org/apache/pinot/core/common/DataBlockCache.java 92.14% <0.00%> (+0.71%) ⬆️
...nMaxValueBasedSelectionOrderByCombineOperator.java 72.72% <0.00%> (+0.75%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bad7106...229df34. Read the comment docs.

Copy link
Member

@richardstartin richardstartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@richardstartin richardstartin merged commit e7f806b into apache:master Feb 14, 2022
@shahsank3t shahsank3t deleted the issue-8198 branch February 14, 2022 13:34
xiangfu0 pushed a commit to xiangfu0/pinot that referenced this pull request Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Showing Reported Size and Estimated Size in human readable format
3 participants