Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[do not merge] Revert "Allocation free DataBlockCache lookups" #8178

Closed

Conversation

richardstartin
Copy link
Member

Reverts #8140

@codecov-commenter
Copy link

Codecov Report

Merging #8178 (c15bf3e) into master (5fa4737) will decrease coverage by 57.24%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #8178       +/-   ##
=============================================
- Coverage     71.41%   14.17%   -57.25%     
+ Complexity     4302       81     -4221     
=============================================
  Files          1623     1578       -45     
  Lines         84312    82443     -1869     
  Branches      12639    12435      -204     
=============================================
- Hits          60213    11684    -48529     
- Misses        19974    69892    +49918     
+ Partials       4125      867     -3258     
Flag Coverage Δ
integration1 ?
integration2 ?
unittests1 ?
unittests2 14.17% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...a/org/apache/pinot/core/common/DataBlockCache.java 0.00% <0.00%> (-92.15%) ⬇️
...ain/java/org/apache/pinot/core/data/table/Key.java 0.00% <0.00%> (-100.00%) ⬇️
.../java/org/apache/pinot/spi/utils/BooleanUtils.java 0.00% <0.00%> (-100.00%) ⬇️
.../java/org/apache/pinot/core/data/table/Record.java 0.00% <0.00%> (-100.00%) ⬇️
.../java/org/apache/pinot/core/util/GroupByUtils.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/config/table/FSTType.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/data/MetricFieldSpec.java 0.00% <0.00%> (-100.00%) ⬇️
...va/org/apache/pinot/spi/utils/BigDecimalUtils.java 0.00% <0.00%> (-100.00%) ⬇️
...java/org/apache/pinot/common/tier/TierFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...java/org/apache/pinot/common/utils/StringUtil.java 0.00% <0.00%> (-100.00%) ⬇️
... and 1293 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fa4737...c15bf3e. Read the comment docs.

@richardstartin richardstartin deleted the revert-8140-allocation-free-datablock-cache branch April 20, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants