-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding scala profile for kafka 2.x build and remove root pom scala dependencies #8174
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8174 +/- ##
============================================
+ Coverage 71.35% 71.44% +0.09%
- Complexity 4306 4307 +1
============================================
Files 1623 1623
Lines 84314 84314
Branches 12640 12640
============================================
+ Hits 60163 60240 +77
+ Misses 20035 19955 -80
- Partials 4116 4119 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
<profile> | ||
<id>scala-2.12</id> | ||
<activation> | ||
<activeByDefault>true</activeByDefault> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This basically means the default scala version got downgraded from 2.13 to 2.12 in the project. Could you elaborate a bit more on the reason of doing that to the description?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason is I've got a lot request for scala 2.12 support, hence make this as default and allow upgrade to 2.13.
Basically this is similar to kafka 0.9 and 2.x, users can build a connector based on the scala version from their enviroment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Pinot users, there is no different in terms of using scala 2.12 or 2.13 built jars.
This is mostly for users who are integrating Pinot code and libs and making their life easier.
05e4594
to
555df51
Compare
555df51
to
b3fd151
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Adding scala profile for kafka 2.x build and remove root pom scala dependencies
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
backward-incompat
, and complete the section below on Release Notes)Does this PR fix a zero-downtime upgrade introduced earlier?
backward-incompat
, and complete the section below on Release Notes)Does this PR otherwise need attention when creating release notes? Things to consider:
release-notes
and complete the section on Release Notes)Release Notes
Documentation