fix flaky test cases with a bit more robust waiting logic #8154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangfu0
approved these changes
Feb 7, 2022
jackjlli
approved these changes
Feb 7, 2022
klsince
commented
Feb 7, 2022
| // jobDetail and jobTrigger are not added atomically by the scheduler, | ||
| // the jobDetail is added to an internal map firstly, and jobTrigger | ||
| // is added to another internal map afterwards, so we check for the existence | ||
| // of jobTrigger with some waits to be more defensive. |
There was a problem hiding this comment.
org.quartz.simpl.RAMJobStore:
public void storeJobAndTrigger(JobDetail newJob, OperableTrigger newTrigger) throws JobPersistenceException {
this.storeJob(newJob, false);
this.storeTrigger(newTrigger, false);
}
Codecov Report
@@ Coverage Diff @@
## master #8154 +/- ##
============================================
+ Coverage 71.39% 71.47% +0.08%
Complexity 4303 4303
============================================
Files 1624 1624
Lines 84198 84303 +105
Branches 12602 12635 +33
============================================
+ Hits 60116 60259 +143
+ Misses 19970 19919 -51
- Partials 4112 4125 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
any thoughts on the compability check failure below? |
klsince
force-pushed
the
fix_flaky_test_cases
branch
from
2f8ece0 to
a6883ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix flaky test cases with a bit more robust waiting logic, as the test cases wait for the ZK event to trigger the call backs.
Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
backward-incompat, and complete the section below on Release Notes)Does this PR fix a zero-downtime upgrade introduced earlier?
backward-incompat, and complete the section below on Release Notes)Does this PR otherwise need attention when creating release notes? Things to consider:
release-notesand complete the section on Release Notes)Release Notes
Documentation