Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add auth token param for segment replace rest APIs #8146

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

klsince
Copy link
Contributor

@klsince klsince commented Feb 7, 2022

Description

Add auth token param for segment replace rest APIs, as done for the other rest APIs in FileUploadDownloadClient

Upgrade Notes

Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

  • Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

  • Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

  • New configuration options
  • Deprecation of configurations
  • Signature changes to public methods/interfaces
  • New plugins added or old plugins removed
  • Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes

Documentation

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2022

Codecov Report

Merging #8146 (5a34e0f) into master (8bbf93a) will decrease coverage by 40.77%.
The diff coverage is 60.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #8146       +/-   ##
=============================================
- Coverage     71.39%   30.62%   -40.78%     
=============================================
  Files          1624     1613       -11     
  Lines         84198    83850      -348     
  Branches      12602    12566       -36     
=============================================
- Hits          60116    25676    -34440     
- Misses        19970    55880    +35910     
+ Partials       4112     2294     -1818     
Flag Coverage Δ
integration1 28.85% <60.00%> (-0.02%) ⬇️
integration2 27.55% <0.00%> (-0.13%) ⬇️
unittests1 ?
unittests2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/pinot/common/utils/FileUploadDownloadClient.java 57.93% <20.00%> (-5.74%) ⬇️
.../tasks/BaseMultipleSegmentsConversionExecutor.java 87.77% <100.00%> (-0.14%) ⬇️
...ot/plugin/minion/tasks/SegmentConversionUtils.java 76.27% <100.00%> (+0.40%) ⬆️
.../java/org/apache/pinot/spi/utils/BooleanUtils.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/config/table/FSTType.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/data/MetricFieldSpec.java 0.00% <0.00%> (-100.00%) ⬇️
...va/org/apache/pinot/spi/utils/BigDecimalUtils.java 0.00% <0.00%> (-100.00%) ⬇️
...java/org/apache/pinot/common/tier/TierFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...a/org/apache/pinot/spi/config/table/TableType.java 0.00% <0.00%> (-100.00%) ⬇️
.../org/apache/pinot/spi/data/DimensionFieldSpec.java 0.00% <0.00%> (-100.00%) ⬇️
... and 1111 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bbf93a...5a34e0f. Read the comment docs.

@Jackie-Jiang Jackie-Jiang merged commit 08f0f32 into apache:master Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants