Storage quota checker NPE for Dimension Tables

[mneedham]

Fixes a null pointer exception on https://github.com/apache/pinot/blob/master/pinot-controller/src/main/java/org/apache/pinot/controller/validation/StorageQuotaChecker.java#L95 because the Helix Resource Manager isn't initialised. That then stops dimension tables from being uploaded.

Upgrade Notes

Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

• Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

• Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

• New configuration options
• Deprecation of configurations
• Signature changes to public methods/interfaces
• New plugins added or old plugins removed

• Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes

Documentation

[codecov-commenter]

Codecov Report

❗ No coverage uploaded for pull request base (master@e59730a). Click here to learn what that means.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #8132   +/-   ##
=========================================
  Coverage          ?   64.72%           
  Complexity        ?     4303           
=========================================
  Files             ?     1579           
  Lines             ?    82262           
  Branches          ?    12393           
=========================================
  Hits              ?    53240           
  Misses            ?    25225           
  Partials          ?     3797           

Flag	Coverage Δ
unittests1	67.94% <ø> (?)
unittests2	14.17% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../pinot/controller/api/upload/SegmentValidator.java	62.50% <100.00%> (ø)
...not/controller/validation/StorageQuotaChecker.java	78.04% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e59730a...9204c70. Read the comment docs.