Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schema and segment crc to SegmentDirectoryContext #8127

Merged
merged 4 commits into from
Feb 4, 2022

Conversation

npawar
Copy link
Contributor

@npawar npawar commented Feb 4, 2022

Adding a few more things to the SegmentDirectoryContext, to complete the context for a SegmentDirectory.

@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2022

Codecov Report

Merging #8127 (b453079) into master (7d74c8c) will increase coverage by 0.01%.
The diff coverage is 95.65%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8127      +/-   ##
============================================
+ Coverage     71.33%   71.34%   +0.01%     
  Complexity     4302     4302              
============================================
  Files          1624     1624              
  Lines         84140    84169      +29     
  Branches      12596    12597       +1     
============================================
+ Hits          60021    60051      +30     
+ Misses        20013    20009       -4     
- Partials       4106     4109       +3     
Flag Coverage Δ
integration1 28.78% <23.91%> (-0.03%) ⬇️
integration2 27.64% <19.56%> (+0.03%) ⬆️
unittests1 67.95% <95.65%> (+<0.01%) ⬆️
unittests2 14.16% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ment/spi/loader/SegmentDirectoryLoaderContext.java 82.14% <89.47%> (+12.14%) ⬆️
.../pinot/core/data/manager/BaseTableDataManager.java 87.65% <100.00%> (+1.07%) ⬆️
...indexsegment/immutable/ImmutableSegmentLoader.java 84.76% <100.00%> (+0.60%) ⬆️
...ndex/converter/SegmentV1V2ToV3FormatConverter.java 77.94% <100.00%> (+0.16%) ⬆️
...a/org/apache/pinot/common/utils/ServiceStatus.java 60.00% <0.00%> (-7.15%) ⬇️
.../pinot/core/query/scheduler/PriorityScheduler.java 80.82% <0.00%> (-2.74%) ⬇️
...core/query/pruner/SelectionQuerySegmentPruner.java 86.36% <0.00%> (-2.28%) ⬇️
...not/broker/broker/helix/ClusterChangeMediator.java 77.65% <0.00%> (-2.13%) ⬇️
...core/startree/operator/StarTreeFilterOperator.java 85.31% <0.00%> (-2.10%) ⬇️
.../pinot/server/starter/helix/BaseServerStarter.java 57.98% <0.00%> (-1.97%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d74c8c...b453079. Read the comment docs.

@npawar npawar merged commit c6ad763 into apache:master Feb 4, 2022
@npawar npawar deleted the crc_segment_dir branch February 4, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants