fix error handling in json functions with default values #8111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klsince
approved these changes
Feb 2, 2022
Codecov Report
@@ Coverage Diff @@
## master #8111 +/- ##
=============================================
- Coverage 71.35% 14.15% -57.20%
+ Complexity 4302 81 -4221
=============================================
Files 1617 1572 -45
Lines 83896 82019 -1877
Branches 12543 12340 -203
=============================================
- Hits 59866 11613 -48253
- Misses 19944 69542 +49598
+ Partials 4086 864 -3222
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
apucher
approved these changes
Feb 2, 2022
Jackie-Jiang
reviewed
Feb 2, 2022
| @@ -89,7 +89,7 @@ public static Object jsonPath(Object object, String jsonPath) { | |||
| if (object instanceof String) { | |||
| return PARSE_CONTEXT.parse((String) object).read(jsonPath, NO_PREDICATES); | |||
| } | |||
| return PARSE_CONTEXT.parse(object).read(jsonPath, NO_PREDICATES); | |||
| return object == null ? null : PARSE_CONTEXT.parse(object).read(jsonPath, NO_PREDICATES); | |||
There was a problem hiding this comment.
Input object should not be null. IMO We can let it throw NPE
Jackie-Jiang
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we caught this in our CI pipeline