Improve the proactive segment clean-up for REVERTED #8071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snleee
force-pushed
the
covering-segment-cleanup-reverted
branch
from
558828c to
17ef9bc
Compare
jackjlli
reviewed
Jan 26, 2022
...ller/src/test/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManagerTest.java
Outdated
Show resolved
Hide resolved
...ller/src/test/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManagerTest.java
Outdated
Show resolved
Hide resolved
...ller/src/test/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManagerTest.java
Outdated
Show resolved
Hide resolved
...ller/src/test/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManagerTest.java
Outdated
Show resolved
Hide resolved
...ller/src/test/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManagerTest.java
Outdated
Show resolved
Hide resolved
snleee
force-pushed
the
covering-segment-cleanup-reverted
branch
2 times, most recently
from
f0e9270 to
aec5e90
Compare
Codecov Report
@@ Coverage Diff @@
## master #8071 +/- ##
============================================
+ Coverage 64.63% 67.88% +3.24%
+ Complexity 4260 4180 -80
============================================
Files 1562 1211 -351
Lines 81525 60564 -20961
Branches 12252 9347 -2905
============================================
- Hits 52695 41113 -11582
+ Misses 25072 16552 -8520
+ Partials 3758 2899 -859
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
jtao15
reviewed
Jan 26, 2022
...ntroller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
Show resolved
Hide resolved
|
LGTM, thanks for the improvement! |
jackjlli
approved these changes
Jan 26, 2022
...ller/src/test/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManagerTest.java
Outdated
Show resolved
Hide resolved
Current code did not handle the proactive clean-up correctly for lineage entries with REVERTED state. - Added the proactive clean-up for 'segmentsTo' for REVERTED during the startSegmentReplacement API call. - Added the proactive clean-up for 'segmentsTo' during the revertSegmentReplacement API call. - Added unit test.
snleee
force-pushed
the
covering-segment-cleanup-reverted
branch
from
aec5e90 to
45de990
Compare
jackjlli
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current code did not handle the proactive clean-up correctly
for lineage entries with REVERTED state.
during the startSegmentReplacement API call.
revertSegmentReplacement API call.