Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a config file to override quickstart configs #8059

Merged
merged 1 commit into from
Jan 24, 2022

Conversation

xiangfu0
Copy link
Contributor

@xiangfu0 xiangfu0 commented Jan 24, 2022

Description

Now users can override quickstart with a config file, e.g:

bin/quick-start-batch.sh -configFile /tmp/quickstart.conf
bin/pinot-admin.sh QuickStart -type batch -configFile /tmp/quickstart.conf

Upgrade Notes

Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

  • Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

  • Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

  • New configuration options
  • Deprecation of configurations
  • Signature changes to public methods/interfaces
  • New plugins added or old plugins removed
  • Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes

Documentation

@xiangfu0 xiangfu0 force-pushed the configurable_quickstart branch from 55542ac to 21aa2d5 Compare January 24, 2022 08:19
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2022

Codecov Report

Merging #8059 (adc6732) into master (e23d5e7) will increase coverage by 40.61%.
The diff coverage is n/a.

❗ Current head adc6732 differs from pull request most recent head 4669d7d. Consider uploading reports for the commit 4669d7d to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##             master    #8059       +/-   ##
=============================================
+ Coverage     30.63%   71.25%   +40.61%     
- Complexity        0     4261     +4261     
=============================================
  Files          1597     1606        +9     
  Lines         83055    83403      +348     
  Branches      12417    12455       +38     
=============================================
+ Hits          25447    59429    +33982     
+ Misses        55361    19928    -35433     
- Partials       2247     4046     +1799     
Flag Coverage Δ
integration1 29.00% <ø> (+0.01%) ⬆️
integration2 27.57% <ø> (-0.05%) ⬇️
unittests1 67.87% <ø> (?)
unittests2 14.25% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...r/helix/SegmentOnlineOfflineStateModelFactory.java 58.49% <0.00%> (-4.72%) ⬇️
...nction/DistinctCountBitmapAggregationFunction.java 41.96% <0.00%> (-2.60%) ⬇️
...n/src/main/java/org/apache/pinot/common/Utils.java 60.46% <0.00%> (-2.33%) ⬇️
...manager/realtime/HLRealtimeSegmentDataManager.java 80.46% <0.00%> (-2.33%) ⬇️
...pache/pinot/core/query/utils/idset/EmptyIdSet.java 25.00% <0.00%> (ø)
...anager/realtime/SegmentBuildTimeLeaseExtender.java 63.23% <0.00%> (ø)
...in/stream/kafka20/KafkaPartitionLevelConsumer.java 66.66% <0.00%> (ø)
...not/ingestion/common/DefaultControllerRestApi.java 0.00% <0.00%> (ø)
...apache/pinot/ingestion/jobs/SegmentTarPushJob.java 70.27% <0.00%> (ø)
...he/pinot/ingestion/utils/JobPreparationHelper.java 0.00% <0.00%> (ø)
... and 1095 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e23d5e7...4669d7d. Read the comment docs.

@xiangfu0 xiangfu0 force-pushed the configurable_quickstart branch from 21aa2d5 to 4669d7d Compare January 24, 2022 09:14
@xiangfu0 xiangfu0 linked an issue Jan 24, 2022 that may be closed by this pull request
@xiangfu0 xiangfu0 mentioned this pull request Jan 24, 2022
3 tasks
@xiangfu0 xiangfu0 merged commit e7ea235 into apache:master Jan 24, 2022
@xiangfu0 xiangfu0 deleted the configurable_quickstart branch January 24, 2022 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow run quickstart with extra configs
3 participants