Adding pinot server grpc metadata acl

[xiangfu0]

Description

Support presto side to auth pinot server using grpc metadata.

Upgrade Notes

Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

• Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

• Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

• New configuration options
• Deprecation of configurations
• Signature changes to public methods/interfaces
• New plugins added or old plugins removed

• Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes

Documentation

[codecov-commenter]

Codecov Report

Merging #8030 (d367ef3) into master (8ca4026) will increase coverage by 0.07%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##             master    #8030      +/-   ##
============================================
+ Coverage     71.17%   71.25%   +0.07%     
- Complexity     4260     4262       +2     
============================================
  Files          1600     1605       +5     
  Lines         83335    83394      +59     
  Branches      12451    12455       +4     
============================================
+ Hits          59316    59422     +106     
+ Misses        19975    19929      -46     
+ Partials       4044     4043       -1     

Flag	Coverage Δ
integration1	29.06% <12.12%> (+0.08%)	⬆️
integration2	27.61% <33.33%> (+0.01%)	⬆️
unittests1	67.87% <56.66%> (+0.02%)	⬆️
unittests2	14.25% <0.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...org/apache/pinot/core/auth/BasicAuthPrincipal.java	72.72% <0.00%> (+2.72%)	⬆️
...che/pinot/server/access/AllowAllAccessFactory.java	80.00% <ø> (ø)
...va/org/apache/pinot/spi/utils/CommonConstants.java	23.63% <ø> (ø)
...che/pinot/core/transport/grpc/GrpcQueryServer.java	42.62% <23.07%> (-6.36%)	⬇️
...che/pinot/server/access/HttpRequesterIdentity.java	50.00% <50.00%> (ø)
...che/pinot/server/access/GrpcRequesterIdentity.java	66.66% <66.66%> (ø)
...he/pinot/server/access/BasicAuthAccessFactory.java	83.33% <83.33%> (ø)
...a/org/apache/pinot/common/metrics/ServerMeter.java	100.00% <100.00%> (ø)
...a/org/apache/pinot/core/transport/QueryServer.java	74.46% <100.00%> (ø)
...ache/pinot/server/access/AccessControlFactory.java	100.00% <100.00%> (ø)
... and 32 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ca4026...d367ef3. Read the comment docs.

[richardstartin]

Is there a way to test this? Given that it's a security feature I would want to know if breaks or is broken.

[xiangfu0]

Is there a way to test this? Given that it's a security feature I would want to know if breaks or is broken.

I'm testing this e2e with presto now. Will add unit test and e2e test for this.

[richardstartin]

👍🏻