Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: Remove remaining occurrences of incubator. #8023

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

mayankshriv
Copy link
Contributor

Description

Removed occurrences of incubator from the code base.

  • Was mostly used in GH links to Pinot landing page, or issues, etc.
  • This links were still working today as incubator-pinot gets redirected to pinot.

Upgrade Notes

Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

  • Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

  • Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

  • New configuration options
  • Deprecation of configurations
  • Signature changes to public methods/interfaces
  • New plugins added or old plugins removed
  • Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes

Documentation

Removed occurrences of `incubator` from the code base.
- Was mostly used in GH links to Pinot landing page, or issues, etc.
- This links were still working today as `incubator-pinot` gets redirected to `pinot`.
@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2022

Codecov Report

Merging #8023 (6e5bff1) into master (eaa5180) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8023      +/-   ##
============================================
+ Coverage     71.39%   71.41%   +0.01%     
- Complexity     4222     4225       +3     
============================================
  Files          1597     1597              
  Lines         82903    82903              
  Branches      12369    12369              
============================================
+ Hits          59189    59204      +15     
+ Misses        19707    19696      -11     
+ Partials       4007     4003       -4     
Flag Coverage Δ
integration1 28.99% <100.00%> (-0.02%) ⬇️
integration2 27.71% <100.00%> (+0.08%) ⬆️
unittests1 68.18% <ø> (+0.04%) ⬆️
unittests2 14.37% <66.66%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ntroller/helix/core/PinotHelixResourceManager.java 65.43% <ø> (ø)
...local/indexsegment/mutable/MutableSegmentImpl.java 59.08% <ø> (ø)
.../java/org/apache/pinot/spi/data/TimeFieldSpec.java 90.90% <ø> (ø)
...pinot/broker/broker/BrokerAdminApiApplication.java 92.68% <100.00%> (ø)
.../controller/api/ControllerAdminApiApplication.java 92.45% <100.00%> (ø)
...apache/pinot/minion/MinionAdminApiApplication.java 91.66% <100.00%> (ø)
...inot/server/starter/helix/AdminApiApplication.java 87.93% <100.00%> (ø)
...pinot/common/utils/fetcher/HttpSegmentFetcher.java 61.53% <0.00%> (-10.26%) ⬇️
...r/helix/SegmentOnlineOfflineStateModelFactory.java 58.49% <0.00%> (-6.61%) ⬇️
.../helix/core/minion/MinionInstancesCleanupTask.java 77.27% <0.00%> (-4.55%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaa5180...6e5bff1. Read the comment docs.

@mayankshriv mayankshriv merged commit 1d1a7d3 into apache:master Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants