Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Debug] [Not For Review] debug UpsertTableSegmentUploadIntegrationTest failure #7991

Closed
wants to merge 1 commit into from

Conversation

klsince
Copy link
Contributor

@klsince klsince commented Jan 11, 2022

Description

Upgrade Notes

Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

  • Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

  • Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

  • New configuration options
  • Deprecation of configurations
  • Signature changes to public methods/interfaces
  • New plugins added or old plugins removed
  • Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes

Documentation

@codecov-commenter
Copy link

Codecov Report

Merging #7991 (f35c935) into master (823aa07) will decrease coverage by 57.07%.
The diff coverage is n/a.

❗ Current head f35c935 differs from pull request most recent head e1ccef3. Consider uploading reports for the commit e1ccef3 to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##             master    #7991       +/-   ##
=============================================
- Coverage     71.35%   14.27%   -57.08%     
+ Complexity     4218       81     -4137     
=============================================
  Files          1595     1550       -45     
  Lines         82748    80881     -1867     
  Branches      12348    12146      -202     
=============================================
- Hits          59046    11548    -47498     
- Misses        19715    68473    +48758     
+ Partials       3987      860     -3127     
Flag Coverage Δ
integration1 ?
integration2 ?
unittests1 ?
unittests2 14.27% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ain/java/org/apache/pinot/core/data/table/Key.java 0.00% <0.00%> (-100.00%) ⬇️
.../java/org/apache/pinot/spi/utils/BooleanUtils.java 0.00% <0.00%> (-100.00%) ⬇️
.../java/org/apache/pinot/core/data/table/Record.java 0.00% <0.00%> (-100.00%) ⬇️
.../java/org/apache/pinot/core/util/GroupByUtils.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/config/table/FSTType.java 0.00% <0.00%> (-100.00%) ⬇️
...ava/org/apache/pinot/spi/data/MetricFieldSpec.java 0.00% <0.00%> (-100.00%) ⬇️
...va/org/apache/pinot/spi/utils/BigDecimalUtils.java 0.00% <0.00%> (-100.00%) ⬇️
...java/org/apache/pinot/common/tier/TierFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...java/org/apache/pinot/common/utils/StringUtil.java 0.00% <0.00%> (-100.00%) ⬇️
...va/org/apache/pinot/core/data/table/BaseTable.java 0.00% <0.00%> (-100.00%) ⬇️
... and 1267 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 823aa07...e1ccef3. Read the comment docs.

@klsince
Copy link
Contributor Author

klsince commented Jan 11, 2022

issue is transient. close for now.

@klsince klsince closed this Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants