async-http-client upgraded #7968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed updated org to AsyncHttpClient Pumped version to 2.12.3 Refactored pinot-java-client and pinot-jdbc-client as per new version
mayankshriv
approved these changes
Dec 30, 2021
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7968 +/- ##
============================================
+ Coverage 71.34% 71.41% +0.06%
- Complexity 4191 4197 +6
============================================
Files 1595 1595
Lines 82568 82579 +11
Branches 12320 12321 +1
============================================
+ Hits 58906 58971 +65
+ Misses 19678 19628 -50
+ Partials 3984 3980 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cbrentharris
added a commit
to cbrentharris/parseq
that referenced
this pull request
Jan 20, 2024
Current usages of async http client when making SSL connections is having issues. Upgrading the client, similar to pinot in this PR apache/pinot#7968
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed updated org to AsyncHttpClient. Its the same library just shifted to different org
Pumped version to 2.12.3
Refactored pinot-java-client and pinot-jdbc-client as per new version
The older
async-http-clientwas giving issues while connecting tohttpsendpoints.async-http-client issue link : https://github.com/AsyncHttpClient/async-http-client/issues/934
pinot issue link : #7382
Upgrade Notes
No downtime upgrade
Release Notes
Documentation