Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Helm Charts to honour readinessEnabled probes flags on the StatefulSets #7891

Merged
merged 1 commit into from
Dec 13, 2021

Conversation

moszutij
Copy link
Contributor

Update Helm Charts to honour readinessEnabled probes flags on the Controller, Broker, Server and Minion StatefulSet. Fixes #7890

Description

Upgrade Notes

Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

  • Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

  • Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

  • New configuration options
  • Deprecation of configurations
  • Signature changes to public methods/interfaces
  • New plugins added or old plugins removed
  • Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes

Documentation

…troller, Broker, Server and Minion StatefulSets
@xiangfu0
Copy link
Contributor

Thanks for fixing this.

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2021

Codecov Report

Merging #7891 (917efd5) into master (12edbdb) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7891      +/-   ##
============================================
+ Coverage     71.28%   71.35%   +0.06%     
  Complexity     4091     4091              
============================================
  Files          1587     1587              
  Lines         82059    82059              
  Branches      12264    12264              
============================================
+ Hits          58498    58550      +52     
+ Misses        19596    19543      -53     
- Partials       3965     3966       +1     
Flag Coverage Δ
integration1 29.23% <ø> (+0.05%) ⬆️
integration2 27.66% <ø> (-0.07%) ⬇️
unittests1 68.41% <ø> (+<0.01%) ⬆️
unittests2 14.41% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...a/manager/realtime/RealtimeSegmentDataManager.java 50.00% <0.00%> (-25.00%) ⬇️
...ache/pinot/core/operator/docidsets/OrDocIdSet.java 86.36% <0.00%> (-11.37%) ⬇️
...lugin/stream/kafka20/KafkaStreamLevelConsumer.java 88.70% <0.00%> (-4.84%) ⬇️
...nction/DistinctCountBitmapAggregationFunction.java 52.84% <0.00%> (-2.60%) ⬇️
.../java/org/apache/pinot/spi/data/TimeFieldSpec.java 88.63% <0.00%> (-2.28%) ⬇️
...manager/realtime/LLRealtimeSegmentDataManager.java 71.93% <0.00%> (-0.83%) ⬇️
.../controller/helix/core/SegmentDeletionManager.java 75.60% <0.00%> (-0.82%) ⬇️
.../helix/core/realtime/SegmentCompletionManager.java 72.00% <0.00%> (-0.82%) ⬇️
...nMaxValueBasedSelectionOrderByCombineOperator.java 71.21% <0.00%> (-0.76%) ⬇️
...a/org/apache/pinot/core/common/DataBlockCache.java 91.44% <0.00%> (-0.66%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12edbdb...917efd5. Read the comment docs.

@Jackie-Jiang Jackie-Jiang merged commit 9c57b4d into apache:master Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pinot Helm Chart should honour the readinessEnabled probe flags on the StatefulSets
4 participants